[coreboot-gerrit] Patch set updated for coreboot: lib/stack: Add stack overrun detection

Timothy Pearson (tpearson@raptorengineeringinc.com) gerrit at coreboot.org
Mon Oct 19 22:33:35 CEST 2015


Timothy Pearson (tpearson at raptorengineeringinc.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11962

-gerrit

commit 3cdfc52d5e3565871ac553242fb143e442094734
Author: Timothy Pearson <tpearson at raptorengineeringinc.com>
Date:   Sat Sep 5 19:31:03 2015 -0500

    lib/stack: Add stack overrun detection
    
    Change-Id: I9a59fcb7cf221ae590a047c520e7aff99e23ecf1
    Signed-off-by: Timothy Pearson <tpearson at raptorengineeringinc.com>
---
 src/lib/stack.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/lib/stack.c b/src/lib/stack.c
index 52dd723..bebeea2 100644
--- a/src/lib/stack.c
+++ b/src/lib/stack.c
@@ -18,6 +18,7 @@ it with the version available from LANL.
  */
 /* Copyright 2000, Ron Minnich, Advanced Computing Lab, LANL
  * rminnich at lanl.gov
+ * Copyright (C) 2015 Timothy Pearson <tpearson at raptorengineeringinc.com>, Raptor Engineering
  */
 
 #include <assert.h>
@@ -33,9 +34,9 @@ int checkstack(void *top_of_stack, int core)
 	u32 *stack = (u32 *) (top_of_stack - stack_size);
 
 	if (stack[0] != 0xDEADBEEF){
-		printk(BIOS_ERR, "Stack overrun on CPU%d. "
+		printk(BIOS_ERR, "Stack overrun on CPU%d (address %p overwritten). "
 			"Increase stack from current %zu bytes\n",
-			core, stack_size);
+			core, stack, stack_size);
 		BUG();
 		return -1;
 	}



More information about the coreboot-gerrit mailing list