[coreboot-gerrit] Patch set updated for coreboot: southbridge/amd/sb700: Indicate iSATA/eSATA port type

Timothy Pearson (tpearson@raptorengineeringinc.com) gerrit at coreboot.org
Sat Oct 17 22:24:29 CEST 2015


Timothy Pearson (tpearson at raptorengineeringinc.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11984

-gerrit

commit 23c446e867ab6550d8300bfad659dc2f8b1abc80
Author: Timothy Pearson <tpearson at raptorengineeringinc.com>
Date:   Tue Jun 9 19:34:16 2015 -0500

    southbridge/amd/sb700: Indicate iSATA/eSATA port type
    
    Change-Id: I8ee757d07c82c151b36def6b709163ff144d244f
    Signed-off-by: Timothy Pearson <tpearson at raptorengineeringinc.com>
---
 src/mainboard/asus/kgpe-d16/mainboard.c | 16 ++++++++++++++++
 src/southbridge/amd/sb700/sata.c        | 19 +++++++++++++++++++
 src/southbridge/amd/sb700/sb700.h       |  1 +
 3 files changed, 36 insertions(+)

diff --git a/src/mainboard/asus/kgpe-d16/mainboard.c b/src/mainboard/asus/kgpe-d16/mainboard.c
index 8de6f26..77e55db 100644
--- a/src/mainboard/asus/kgpe-d16/mainboard.c
+++ b/src/mainboard/asus/kgpe-d16/mainboard.c
@@ -99,6 +99,22 @@ void sb7xx_51xx_setup_sata_phys(struct device *dev)
 	pci_write_config16(dev, 0xaa, 0xa07a);
 }
 
+/* override the default SATA port setup */
+void sb7xx_51xx_setup_sata_port_indication(void *sata_bar5)
+{
+	uint32_t dword;
+
+	/* RPR7.9 Program Port Indication Registers */
+	dword = read32(sata_bar5 + 0xf8);
+	dword &= ~(0x3f << 12);	/* All ports are iSATA */
+	dword &= ~0x3f;
+	write32(sata_bar5 + 0xf8, dword);
+
+	dword = read32(sata_bar5 + 0xfc);
+	dword &= ~(0x1 << 20);	/* No eSATA ports are present */
+	write32(sata_bar5 + 0xfc, dword);
+}
+
 struct chip_operations mainboard_ops = {
 	.enable_dev = mainboard_enable,
 };
diff --git a/src/southbridge/amd/sb700/sata.c b/src/southbridge/amd/sb700/sata.c
index c0b3cd5..dda2fc3 100644
--- a/src/southbridge/amd/sb700/sata.c
+++ b/src/southbridge/amd/sb700/sata.c
@@ -78,6 +78,23 @@ void __attribute__((weak)) sb7xx_51xx_setup_sata_phys(struct device *dev)
 	pci_write_config16(dev, 0xaa, 0xA07A);
 }
 
+/* This function can be overloaded in mainboard.c */
+void __attribute__((weak)) sb7xx_51xx_setup_sata_port_indication(void *sata_bar5)
+{
+	uint32_t dword;
+
+	/* RPR7.9 Program Port Indication Registers */
+	dword = read32(sata_bar5 + 0xf8);
+	dword &= ~(0x3f << 12);	/* Ports 0 and 1 are eSATA */
+	dword |= (0x3 << 12);
+	dword &= ~0x3f;
+	write32(sata_bar5 + 0xf8, dword);
+
+	dword = read32(sata_bar5 + 0xfc);
+	dword |= 0x1 << 20;	/* At least one eSATA port is present */
+	write32(sata_bar5 + 0xfc, dword);
+}
+
 static void sata_init(struct device *dev)
 {
 	u8 byte;
@@ -248,7 +265,9 @@ static void sata_init(struct device *dev)
 	/* Program the watchdog counter to 0x10 */
 	byte = 0x10;
 	pci_write_config8(dev, 0x46, byte);
+
 	sb7xx_51xx_setup_sata_phys(dev);
+	sb7xx_51xx_setup_sata_port_indication(sata_bar5);
 
 	/* Enable the I/O, MM, BusMaster access for SATA */
 	byte = pci_read_config8(dev, 0x4);
diff --git a/src/southbridge/amd/sb700/sb700.h b/src/southbridge/amd/sb700/sb700.h
index 941a4fd..8f792e7 100644
--- a/src/southbridge/amd/sb700/sb700.h
+++ b/src/southbridge/amd/sb700/sb700.h
@@ -74,6 +74,7 @@ void sb7xx_51xx_before_pci_init(void);
 #include <device/pci.h>
 /* allow override in mainboard.c */
 void sb7xx_51xx_setup_sata_phys(struct device *dev);
+void sb7xx_51xx_setup_sata_port_indication(void *sata_bar5);
 
 #endif
 



More information about the coreboot-gerrit mailing list