[coreboot-gerrit] New patch to review for coreboot: northbridge/amd/amdfam10: Rename mislabeled iommu nvram option to gart

Timothy Pearson (tpearson@raptorengineeringinc.com) gerrit at coreboot.org
Fri Oct 16 21:46:55 CEST 2015


Timothy Pearson (tpearson at raptorengineeringinc.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12046

-gerrit

commit 0ea48c4edcfe9c92affaa679a3e0e788f8264a4b
Author: Timothy Pearson <tpearson at raptorengineeringinc.com>
Date:   Tue Aug 11 17:52:03 2015 -0500

    northbridge/amd/amdfam10: Rename mislabeled iommu nvram option to gart
    
    Change-Id: Ia24102e164eb5753ade3f9b5ab21eba2fa60836b
    Signed-off-by: Timothy Pearson <tpearson at raptorengineeringinc.com>
---
 src/northbridge/amd/amdfam10/misc_control.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/northbridge/amd/amdfam10/misc_control.c b/src/northbridge/amd/amdfam10/misc_control.c
index 1057ac1..4710876 100644
--- a/src/northbridge/amd/amdfam10/misc_control.c
+++ b/src/northbridge/amd/amdfam10/misc_control.c
@@ -43,7 +43,7 @@
  *
  * @param dev
  *
- * There is only one AGP aperture resource needed. The resoruce is added to
+ * There is only one AGP aperture resource needed. The resource is added to
  * the northbridge of BSP.
  *
  * The same trick can be used to augment legacy VGA resources which can
@@ -55,7 +55,7 @@
 static void mcf3_read_resources(device_t dev)
 {
 	struct resource *resource;
-	unsigned char iommu;
+	unsigned char gart;
 	/* Read the generic PCI resources */
 	pci_dev_read_resources(dev);
 
@@ -64,13 +64,13 @@ static void mcf3_read_resources(device_t dev)
 		return;
 	}
 
-	iommu = 1;
-	get_option(&iommu, "iommu");
+	gart = 1;
+	get_option(&gart, "gart");
 
-	if (iommu) {
+	if (gart) {
 		/* Add a Gart apeture resource */
 		resource = new_resource(dev, 0x94);
-		resource->size = iommu?CONFIG_AGP_APERTURE_SIZE:1;
+		resource->size = gart?CONFIG_AGP_APERTURE_SIZE:1;
 		resource->align = log2(resource->size);
 		resource->gran  = log2(resource->size);
 		resource->limit = 0xffffffff; /* 4G */



More information about the coreboot-gerrit mailing list