[coreboot-gerrit] New patch to review for coreboot: northbridge/amd/amdmct: Fix crash on startup due to NULL pointer access

Timothy Pearson (tpearson@raptorengineeringinc.com) gerrit at coreboot.org
Fri Oct 16 21:46:09 CEST 2015


Timothy Pearson (tpearson at raptorengineeringinc.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11995

-gerrit

commit 06ed6bcfbad14c91441fa0e690c0bd206fc9911d
Author: Timothy Pearson <tpearson at raptorengineeringinc.com>
Date:   Sat Jun 20 14:40:56 2015 -0500

    northbridge/amd/amdmct: Fix crash on startup due to NULL pointer access
    
    Change-Id: I47089f2ad886a6fda4e0cd4472efd975bb8e06c5
    Signed-off-by: Timothy Pearson <tpearson at raptorengineeringinc.com>
---
 src/northbridge/amd/amdmct/wrappers/mcti_d.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/northbridge/amd/amdmct/wrappers/mcti_d.c b/src/northbridge/amd/amdmct/wrappers/mcti_d.c
index d1da07b..2376b20 100644
--- a/src/northbridge/amd/amdmct/wrappers/mcti_d.c
+++ b/src/northbridge/amd/amdmct/wrappers/mcti_d.c
@@ -353,11 +353,10 @@ static void mctGet_MaxLoadFreq(struct DCTStatStruc *pDCTstat)
 #endif
 
 	for (i = 0; i < 2; i++) {
-		sDCTStruct *pDCTData = pDCTstat->C_DCTPtr[i];
 		highest_rank_count[i] = 0x0;
 		for (dimm = 0; dimm < MAX_DIMMS_SUPPORTED; dimm++) {
-			if (pDCTData->DimmRanks[dimm] > highest_rank_count[i])
-				highest_rank_count[i] = pDCTData->DimmRanks[dimm];
+			if (pDCTstat->DimmRanks[dimm] > highest_rank_count[i])
+				highest_rank_count[i] = pDCTstat->DimmRanks[dimm];
 		}
 	}
 



More information about the coreboot-gerrit mailing list