[coreboot-gerrit] Patch set updated for coreboot: google/auron: use xxd instead of a home-grown hex-to-bin parser
Georg Wicherski (gw@oxff.net)
gerrit at coreboot.org
Thu Oct 15 13:00:19 CEST 2015
Georg Wicherski (gw at oxff.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11868
-gerrit
commit cb03e03b5d0a2b7aa8c3ce45cf1ba22b638576fc
Author: Patrick Georgi <pgeorgi at chromium.org>
Date: Thu Oct 15 10:50:35 2015 +0200
google/auron: use xxd instead of a home-grown hex-to-bin parser
Imitate samsung/lumpy. Verified that the output looks reasonable.
Change-Id: Ia83e3c7dd31a18aac5621f418af76b3f7101cee1
Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
---
.../google/auron/spd/Elpida_EDJ4216EFBG.spd.hex | 17 -----------------
.../google/auron/spd/Elpida_EDJ4216EFBG.spd.xxd | 16 ++++++++++++++++
.../google/auron/spd/Hynix_HMT425S6AFR6A.spd.hex | 17 -----------------
.../google/auron/spd/Hynix_HMT425S6AFR6A.spd.xxd | 16 ++++++++++++++++
src/mainboard/google/auron/spd/Makefile.inc | 6 ++----
.../google/auron/spd/Micron_4KTF25664HZ.spd.hex | 17 -----------------
.../google/auron/spd/Micron_4KTF25664HZ.spd.xxd | 16 ++++++++++++++++
src/mainboard/google/auron/spd/empty.spd.hex | 16 ----------------
src/mainboard/google/auron/spd/empty.spd.xxd | 16 ++++++++++++++++
9 files changed, 66 insertions(+), 71 deletions(-)
diff --git a/src/mainboard/google/auron/spd/Elpida_EDJ4216EFBG.spd.hex b/src/mainboard/google/auron/spd/Elpida_EDJ4216EFBG.spd.hex
deleted file mode 100644
index eb41f0b..0000000
--- a/src/mainboard/google/auron/spd/Elpida_EDJ4216EFBG.spd.hex
+++ /dev/null
@@ -1,17 +0,0 @@
-# Elpida EDJ4216EFBG-GN-F
-92 12 0B 03 04 19 02 02 03 11 01 08 0A 00 FE 00
-69 78 69 3C 69 11 18 81 20 08 3C 3C 01 40 83 81
-00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
-00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
-00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
-00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
-00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
-00 00 00 00 00 02 FE 00 00 00 00 00 00 00 A1 CE
-45 44 4A 34 32 31 36 45 46 42 47 2D 47 4E 2D 46
-00 00 00 00 02 FE 00 00 00 00 00 00 00 00 00 00
-00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
-FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF
-FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF
-FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF
-FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF
-FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF
diff --git a/src/mainboard/google/auron/spd/Elpida_EDJ4216EFBG.spd.xxd b/src/mainboard/google/auron/spd/Elpida_EDJ4216EFBG.spd.xxd
new file mode 100644
index 0000000..b831e92
--- /dev/null
+++ b/src/mainboard/google/auron/spd/Elpida_EDJ4216EFBG.spd.xxd
@@ -0,0 +1,16 @@
+0000000: 92 12 0b 03 04 19 02 02 03 11 01 08 0a 00 fe 00 ................
+0000010: 69 78 69 3c 69 11 18 81 20 08 3c 3c 01 40 83 81 ixi<i... .<<. at ..
+0000020: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
+0000030: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
+0000040: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
+0000050: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
+0000060: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
+0000070: 00 00 00 00 00 02 fe 00 00 00 00 00 00 00 a1 ce ................
+0000080: 45 44 4a 34 32 31 36 45 46 42 47 2d 47 4e 2d 46 EDJ4216EFBG-GN-F
+0000090: 00 00 00 00 02 fe 00 00 00 00 00 00 00 00 00 00 ................
+00000a0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
+00000b0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ................
+00000c0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ................
+00000d0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ................
+00000e0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ................
+00000f0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ................
diff --git a/src/mainboard/google/auron/spd/Hynix_HMT425S6AFR6A.spd.hex b/src/mainboard/google/auron/spd/Hynix_HMT425S6AFR6A.spd.hex
deleted file mode 100644
index 7b09327..0000000
--- a/src/mainboard/google/auron/spd/Hynix_HMT425S6AFR6A.spd.hex
+++ /dev/null
@@ -1,17 +0,0 @@
-# Hynix HMT425S6AFR6A-PBA
-92 12 0B 03 04 19 02 02 03 52 01 08 0A 00 FE 00
-69 78 69 3C 69 11 18 81 20 08 3C 3C 01 40 83 01
-00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
-00 00 00 00 00 00 00 00 00 00 00 00 0F 11 62 00
-00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
-00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
-00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
-00 00 00 00 00 80 AD 01 00 00 00 00 00 00 FF AB
-48 4D 54 34 32 35 53 36 41 46 52 36 41 2D 50 42
-20 20 4E 30 80 AD 00 00 00 00 00 00 00 00 00 00
-00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
-FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF
-FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF
-FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF
-FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF
-FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF
diff --git a/src/mainboard/google/auron/spd/Hynix_HMT425S6AFR6A.spd.xxd b/src/mainboard/google/auron/spd/Hynix_HMT425S6AFR6A.spd.xxd
new file mode 100644
index 0000000..7457006
--- /dev/null
+++ b/src/mainboard/google/auron/spd/Hynix_HMT425S6AFR6A.spd.xxd
@@ -0,0 +1,16 @@
+0000000: 92 12 0b 03 04 19 02 02 03 52 01 08 0a 00 fe 00 .........R......
+0000010: 69 78 69 3c 69 11 18 81 20 08 3c 3c 01 40 83 01 ixi<i... .<<. at ..
+0000020: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
+0000030: 00 00 00 00 00 00 00 00 00 00 00 00 0f 11 62 00 ..............b.
+0000040: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
+0000050: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
+0000060: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
+0000070: 00 00 00 00 00 80 ad 01 00 00 00 00 00 00 ff ab ................
+0000080: 48 4d 54 34 32 35 53 36 41 46 52 36 41 2d 50 42 HMT425S6AFR6A-PB
+0000090: 20 20 4e 30 80 ad 00 00 00 00 00 00 00 00 00 00 N0............
+00000a0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
+00000b0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ................
+00000c0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ................
+00000d0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ................
+00000e0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ................
+00000f0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ................
diff --git a/src/mainboard/google/auron/spd/Makefile.inc b/src/mainboard/google/auron/spd/Makefile.inc
index 7b0292d..acd16f8 100644
--- a/src/mainboard/google/auron/spd/Makefile.inc
+++ b/src/mainboard/google/auron/spd/Makefile.inc
@@ -39,14 +39,12 @@ SPD_SOURCES += empty # 0b1101
SPD_SOURCES += empty # 0b1110
SPD_SOURCES += empty # 0b1111
-SPD_DEPS := $(foreach f, $(SPD_SOURCES), src/mainboard/$(MAINBOARDDIR)/spd/$(f).spd.hex)
+SPD_DEPS := $(foreach f, $(SPD_SOURCES), src/mainboard/$(MAINBOARDDIR)/spd/$(f).spd.xxd)
# Include spd rom data
$(SPD_BIN): $(SPD_DEPS)
for f in $+; \
- do for c in $$(cat $$f | grep -v ^#); \
- do echo -e -n "\\x$$c"; \
- done; \
+ do xxd -rg1 $$f; \
done > $@
cbfs-files-y += spd.bin
diff --git a/src/mainboard/google/auron/spd/Micron_4KTF25664HZ.spd.hex b/src/mainboard/google/auron/spd/Micron_4KTF25664HZ.spd.hex
deleted file mode 100644
index cbe9e4f..0000000
--- a/src/mainboard/google/auron/spd/Micron_4KTF25664HZ.spd.hex
+++ /dev/null
@@ -1,17 +0,0 @@
-# Micron 4KTF25664HZ-1G6E1
-92 11 0B 03 04 19 02 02 03 11 01 08 0A 00 FE 00
-69 78 69 3C 69 11 18 81 20 08 3C 3C 01 40 83 05
-00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
-00 00 00 00 00 00 00 00 00 00 00 00 0F 01 02 00
-00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
-00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
-00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
-00 00 00 00 00 80 2C 00 00 00 00 00 00 00 AD 75
-34 4B 54 46 32 35 36 36 34 48 5A 2D 31 47 36 45
-31 20 45 31 80 2C 00 00 00 00 00 00 00 00 00 00
-00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
-FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF
-FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF
-FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF
-FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF
-FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF
diff --git a/src/mainboard/google/auron/spd/Micron_4KTF25664HZ.spd.xxd b/src/mainboard/google/auron/spd/Micron_4KTF25664HZ.spd.xxd
new file mode 100644
index 0000000..0099da2
--- /dev/null
+++ b/src/mainboard/google/auron/spd/Micron_4KTF25664HZ.spd.xxd
@@ -0,0 +1,16 @@
+0000000: 92 11 0b 03 04 19 02 02 03 11 01 08 0a 00 fe 00 ................
+0000010: 69 78 69 3c 69 11 18 81 20 08 3c 3c 01 40 83 05 ixi<i... .<<. at ..
+0000020: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
+0000030: 00 00 00 00 00 00 00 00 00 00 00 00 0f 01 02 00 ................
+0000040: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
+0000050: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
+0000060: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
+0000070: 00 00 00 00 00 80 2c 00 00 00 00 00 00 00 ad 75 ......,........u
+0000080: 34 4b 54 46 32 35 36 36 34 48 5a 2d 31 47 36 45 4KTF25664HZ-1G6E
+0000090: 31 20 45 31 80 2c 00 00 00 00 00 00 00 00 00 00 1 E1.,..........
+00000a0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
+00000b0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ................
+00000c0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ................
+00000d0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ................
+00000e0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ................
+00000f0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ................
diff --git a/src/mainboard/google/auron/spd/empty.spd.hex b/src/mainboard/google/auron/spd/empty.spd.hex
deleted file mode 100644
index 9ec39f1..0000000
--- a/src/mainboard/google/auron/spd/empty.spd.hex
+++ /dev/null
@@ -1,16 +0,0 @@
-00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
-00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
-00 80 00 00 00 00 00 00 00 00 00 00 00 00 00 00
-00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
-00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
-00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
-00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
-00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
-00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
-00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
-00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
-00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
-00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
-00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
-00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
-00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
diff --git a/src/mainboard/google/auron/spd/empty.spd.xxd b/src/mainboard/google/auron/spd/empty.spd.xxd
new file mode 100644
index 0000000..1628923
--- /dev/null
+++ b/src/mainboard/google/auron/spd/empty.spd.xxd
@@ -0,0 +1,16 @@
+0000000: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
+0000010: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
+0000020: 00 80 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
+0000030: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
+0000040: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
+0000050: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
+0000060: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
+0000070: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
+0000080: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
+0000090: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
+00000a0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
+00000b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
+00000c0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
+00000d0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
+00000e0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
+00000f0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
More information about the coreboot-gerrit
mailing list