[coreboot-gerrit] Patch merged into coreboot/master: skylake: ACPI: Fix compiler warnings with iasl-20150717

gerrit at coreboot.org gerrit at coreboot.org
Wed Oct 14 20:33:42 CEST 2015


the following patch was just integrated into master:
commit aa1b6b06ef506eeb4cc73139b473a0aeb9ee26ba
Author: Duncan Laurie <dlaurie at chromium.org>
Date:   Wed Sep 23 18:01:45 2015 -0700

    skylake: ACPI: Fix compiler warnings with iasl-20150717
    
    Updating to a new IASL introduces a lot of warnings that are
    not serious issues but can be fixed with some reworks.
    
    - Method local variables that are set but never used now warn,
    when needing to read back a register the ordering is now changed
    to set the value in Local0 first so the compiler does not complain.
    - Methods that create an object must be serialized
    - A ResourceTemplate declared inside a _CRS with a named variable
    does not seem to be able to compile without a warning.  To fix
    this move the ResourceTemplate outside the _CRS method.
    - The DPTF CPU code was still using the old legacy \_PR.CPUx
    instead of the new \_PR.CPxx definitions.
    
    BUG=chrome-os-partner:44622
    BRANCH=none
    TEST=build glados with iasl-20150717 and see no warnings
    
    Original-Change-Id: I4a66c7eb6495aac4ae1aa42100c846725c1a04d2
    Original-Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/302168
    Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>
    
    Change-Id: Ia3af802ca2faab4f1c59e73f2ce31a65c7e862e0
    Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
    Signed-off-by: Aaron Durbin <adurbin at chromium.org>
    Reviewed-on: http://review.coreboot.org/11812
    Tested-by: build bot (Jenkins)
    Reviewed-by: Duncan Laurie <dlaurie at google.com>


See http://review.coreboot.org/11812 for details.

-gerrit



More information about the coreboot-gerrit mailing list