[coreboot-gerrit] New patch to review for coreboot: southbridge/intel: Move `i82801gx/acpi/platform.asl` to `common/acpi`

Paul Menzel (paulepanter@users.sourceforge.net) gerrit at coreboot.org
Tue Oct 13 21:42:31 CEST 2015


Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11881

-gerrit

commit 8159115913b34a5aef66976d8afb609249c56386
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Tue Oct 13 21:19:49 2015 +0200

    southbridge/intel: Move `i82801gx/acpi/platform.asl` to `common/acpi`
    
    Commit 24813c14 (i945: Consolidate acpi/platform.asl) creates the file
    in the directory `src/southbridge/intel/i82801gx/acpi`. Devices with the
    southbridge `intel/i82801ix`, like the laptop Lenovo X200, use the exact
    same ASL code though. So share this in the directory
    `src/southbridge/intel/common/acpi`.
    
    Change-Id: I33b7993bcdbef7233ed85a683b2858ac72c1d642
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
---
 src/mainboard/apple/macbook21/dsdt.asl           |   2 +-
 src/mainboard/getac/p470/dsdt.asl                |   2 +-
 src/mainboard/ibase/mb899/dsdt.asl               |   2 +-
 src/mainboard/intel/d945gclf/dsdt.asl            |   2 +-
 src/mainboard/kontron/986lcd-m/dsdt.asl          |   2 +-
 src/mainboard/lenovo/t60/dsdt.asl                |   2 +-
 src/mainboard/lenovo/x60/dsdt.asl                |   2 +-
 src/mainboard/roda/rk886ex/dsdt.asl              |   2 +-
 src/southbridge/intel/common/acpi/platform.asl   | 104 +++++++++++++++++++++++
 src/southbridge/intel/i82801gx/acpi/platform.asl | 104 -----------------------
 10 files changed, 112 insertions(+), 112 deletions(-)

diff --git a/src/mainboard/apple/macbook21/dsdt.asl b/src/mainboard/apple/macbook21/dsdt.asl
index fdd4e36..0064a33 100644
--- a/src/mainboard/apple/macbook21/dsdt.asl
+++ b/src/mainboard/apple/macbook21/dsdt.asl
@@ -36,7 +36,7 @@ DefinitionBlock(
 
 	// global NVS and variables
 	#include <southbridge/intel/i82801gx/acpi/globalnvs.asl>
-	#include <southbridge/intel/i82801gx/acpi/platform.asl>
+	#include <southbridge/intel/common/acpi/platform.asl>
 
 	#include <cpu/intel/common/acpi/cpu.asl>
 
diff --git a/src/mainboard/getac/p470/dsdt.asl b/src/mainboard/getac/p470/dsdt.asl
index fa7a113..fd80223 100644
--- a/src/mainboard/getac/p470/dsdt.asl
+++ b/src/mainboard/getac/p470/dsdt.asl
@@ -30,7 +30,7 @@ DefinitionBlock(
 	0x20090419	// OEM revision
 )
 {
-	#include <southbridge/intel/i82801gx/acpi/platform.asl>
+	#include <southbridge/intel/common/acpi/platform.asl>
 
 	// Some generic macros
 	#include "acpi/platform.asl"
diff --git a/src/mainboard/ibase/mb899/dsdt.asl b/src/mainboard/ibase/mb899/dsdt.asl
index ef42039..8936d91 100644
--- a/src/mainboard/ibase/mb899/dsdt.asl
+++ b/src/mainboard/ibase/mb899/dsdt.asl
@@ -32,7 +32,7 @@ DefinitionBlock(
 	// global NVS and variables
 	#include <southbridge/intel/i82801gx/acpi/globalnvs.asl>
 
-	#include <southbridge/intel/i82801gx/acpi/platform.asl>
+	#include <southbridge/intel/common/acpi/platform.asl>
 
 	// General Purpose Events
 	//#include "acpi/gpe.asl"
diff --git a/src/mainboard/intel/d945gclf/dsdt.asl b/src/mainboard/intel/d945gclf/dsdt.asl
index 8cd9c14..4a0525b 100644
--- a/src/mainboard/intel/d945gclf/dsdt.asl
+++ b/src/mainboard/intel/d945gclf/dsdt.asl
@@ -31,7 +31,7 @@ DefinitionBlock(
 
 	// global NVS and variables
 	#include <southbridge/intel/i82801gx/acpi/globalnvs.asl>
-	#include <southbridge/intel/i82801gx/acpi/platform.asl>
+	#include <southbridge/intel/common/acpi/platform.asl>
 
 	// General Purpose Events
 	//#include "acpi/gpe.asl"
diff --git a/src/mainboard/kontron/986lcd-m/dsdt.asl b/src/mainboard/kontron/986lcd-m/dsdt.asl
index 595c04e..4549716 100644
--- a/src/mainboard/kontron/986lcd-m/dsdt.asl
+++ b/src/mainboard/kontron/986lcd-m/dsdt.asl
@@ -31,7 +31,7 @@ DefinitionBlock(
 
 	// global NVS and variables
 	#include <southbridge/intel/i82801gx/acpi/globalnvs.asl>
-	#include <southbridge/intel/i82801gx/acpi/platform.asl>
+	#include <southbridge/intel/common/acpi/platform.asl>
 
 	// General Purpose Events
 	//#include "acpi/gpe.asl"
diff --git a/src/mainboard/lenovo/t60/dsdt.asl b/src/mainboard/lenovo/t60/dsdt.asl
index bbdb842..cbfa0ed 100644
--- a/src/mainboard/lenovo/t60/dsdt.asl
+++ b/src/mainboard/lenovo/t60/dsdt.asl
@@ -37,7 +37,7 @@ DefinitionBlock(
 
 	// global NVS and variables
 	#include <southbridge/intel/i82801gx/acpi/globalnvs.asl>
-	#include <southbridge/intel/i82801gx/acpi/platform.asl>
+	#include <southbridge/intel/common/acpi/platform.asl>
 
 	// General Purpose Events
 	#include "acpi/gpe.asl"
diff --git a/src/mainboard/lenovo/x60/dsdt.asl b/src/mainboard/lenovo/x60/dsdt.asl
index c31bd6d..b4bbcc3 100644
--- a/src/mainboard/lenovo/x60/dsdt.asl
+++ b/src/mainboard/lenovo/x60/dsdt.asl
@@ -39,7 +39,7 @@ DefinitionBlock(
 
 	// global NVS and variables
 	#include <southbridge/intel/i82801gx/acpi/globalnvs.asl>
-	#include <southbridge/intel/i82801gx/acpi/platform.asl>
+	#include <southbridge/intel/common/acpi/platform.asl>
 
 	// General Purpose Events
 	#include "acpi/gpe.asl"
diff --git a/src/mainboard/roda/rk886ex/dsdt.asl b/src/mainboard/roda/rk886ex/dsdt.asl
index 477425f..c16d27d 100644
--- a/src/mainboard/roda/rk886ex/dsdt.asl
+++ b/src/mainboard/roda/rk886ex/dsdt.asl
@@ -32,7 +32,7 @@ DefinitionBlock(
 
 	// global NVS and variables
 	#include <southbridge/intel/i82801gx/acpi/globalnvs.asl>
-	#include <southbridge/intel/i82801gx/acpi/platform.asl>
+	#include <southbridge/intel/common/acpi/platform.asl>
 
 	// General Purpose Events
 	#include "acpi/gpe.asl"
diff --git a/src/southbridge/intel/common/acpi/platform.asl b/src/southbridge/intel/common/acpi/platform.asl
new file mode 100644
index 0000000..5636e10
--- /dev/null
+++ b/src/southbridge/intel/common/acpi/platform.asl
@@ -0,0 +1,104 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright (C) 2007-2009 coresystems GmbH
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; version 2 of
+ * the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc.
+ */
+
+/* The APM port can be used for generating software SMIs */
+
+OperationRegion (APMP, SystemIO, 0xb2, 2)
+Field (APMP, ByteAcc, NoLock, Preserve)
+{
+	APMC, 8,	// APM command
+	APMS, 8		// APM status
+}
+
+/* Port 80 POST */
+
+OperationRegion (POST, SystemIO, 0x80, 1)
+Field (POST, ByteAcc, Lock, Preserve)
+{
+	DBG0, 8
+}
+
+/* SMI I/O Trap */
+Method(TRAP, 1, Serialized)
+{
+	Store (Arg0, SMIF)	// SMI Function
+	Store (0, TRP0)		// Generate trap
+	Return (SMIF)		// Return value of SMI handler
+}
+
+/* The _PIC method is called by the OS to choose between interrupt
+ * routing via the i8259 interrupt controller or the APIC.
+ *
+ * _PIC is called with a parameter of 0 for i8259 configuration and
+ * with a parameter of 1 for Local Apic/IOAPIC configuration.
+ */
+
+Method(_PIC, 1)
+{
+	// Remember the OS' IRQ routing choice.
+	Store(Arg0, PICM)
+}
+
+Method(GOS, 0)
+{
+	/* Determine the Operating System and save the value in OSYS.
+	 * We have to do this in order to be able to work around
+	 * certain windows bugs.
+	 *
+	 *    OSYS value | Operating System
+	 *    -----------+------------------
+	 *       2000    | Windows 2000
+	 *       2001    | Windows XP(+SP1)
+	 *       2002    | Windows XP SP2
+	 *       2006    | Windows Vista
+	 *       ????    | Windows 7
+	 */
+
+	/* Let's assume we're running at least Windows 2000 */
+	Store (2000, OSYS)
+
+	If (CondRefOf(_OSI, Local0)) {
+		/* Linux answers _OSI with "True" for a couple of
+		 * Windows version queries. But unlike Windows it
+		 * needs a Video repost, so let's determine whether
+		 * we're running Linux.
+		 */
+
+		If (_OSI("Linux")) {
+			Store (1, LINX)
+		}
+
+		If (_OSI("Windows 2001")) {
+			Store (2001, OSYS)
+		}
+
+		If (_OSI("Windows 2001 SP1")) {
+			Store (2001, OSYS)
+		}
+
+		If (_OSI("Windows 2001 SP2")) {
+			Store (2002, OSYS)
+		}
+
+		If (_OSI("Windows 2006")) {
+			Store (2006, OSYS)
+		}
+	}
+}
diff --git a/src/southbridge/intel/i82801gx/acpi/platform.asl b/src/southbridge/intel/i82801gx/acpi/platform.asl
deleted file mode 100644
index 5636e10..0000000
--- a/src/southbridge/intel/i82801gx/acpi/platform.asl
+++ /dev/null
@@ -1,104 +0,0 @@
-/*
- * This file is part of the coreboot project.
- *
- * Copyright (C) 2007-2009 coresystems GmbH
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation; version 2 of
- * the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc.
- */
-
-/* The APM port can be used for generating software SMIs */
-
-OperationRegion (APMP, SystemIO, 0xb2, 2)
-Field (APMP, ByteAcc, NoLock, Preserve)
-{
-	APMC, 8,	// APM command
-	APMS, 8		// APM status
-}
-
-/* Port 80 POST */
-
-OperationRegion (POST, SystemIO, 0x80, 1)
-Field (POST, ByteAcc, Lock, Preserve)
-{
-	DBG0, 8
-}
-
-/* SMI I/O Trap */
-Method(TRAP, 1, Serialized)
-{
-	Store (Arg0, SMIF)	// SMI Function
-	Store (0, TRP0)		// Generate trap
-	Return (SMIF)		// Return value of SMI handler
-}
-
-/* The _PIC method is called by the OS to choose between interrupt
- * routing via the i8259 interrupt controller or the APIC.
- *
- * _PIC is called with a parameter of 0 for i8259 configuration and
- * with a parameter of 1 for Local Apic/IOAPIC configuration.
- */
-
-Method(_PIC, 1)
-{
-	// Remember the OS' IRQ routing choice.
-	Store(Arg0, PICM)
-}
-
-Method(GOS, 0)
-{
-	/* Determine the Operating System and save the value in OSYS.
-	 * We have to do this in order to be able to work around
-	 * certain windows bugs.
-	 *
-	 *    OSYS value | Operating System
-	 *    -----------+------------------
-	 *       2000    | Windows 2000
-	 *       2001    | Windows XP(+SP1)
-	 *       2002    | Windows XP SP2
-	 *       2006    | Windows Vista
-	 *       ????    | Windows 7
-	 */
-
-	/* Let's assume we're running at least Windows 2000 */
-	Store (2000, OSYS)
-
-	If (CondRefOf(_OSI, Local0)) {
-		/* Linux answers _OSI with "True" for a couple of
-		 * Windows version queries. But unlike Windows it
-		 * needs a Video repost, so let's determine whether
-		 * we're running Linux.
-		 */
-
-		If (_OSI("Linux")) {
-			Store (1, LINX)
-		}
-
-		If (_OSI("Windows 2001")) {
-			Store (2001, OSYS)
-		}
-
-		If (_OSI("Windows 2001 SP1")) {
-			Store (2001, OSYS)
-		}
-
-		If (_OSI("Windows 2001 SP2")) {
-			Store (2002, OSYS)
-		}
-
-		If (_OSI("Windows 2006")) {
-			Store (2006, OSYS)
-		}
-	}
-}



More information about the coreboot-gerrit mailing list