[coreboot-gerrit] Patch merged into coreboot/master: cbfs: don't load x86 programs over the top of read-only media

gerrit at coreboot.org gerrit at coreboot.org
Mon Oct 12 01:56:48 CEST 2015


the following patch was just integrated into master:
commit ed253c8fd80573b2182aa5fd27033750cff48c0b
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Wed Oct 7 17:22:42 2015 -0500

    cbfs: don't load x86 programs over the top of read-only media
    
    On x86 the early stages are currently execute-in-place which
    means they live in the memory-mapped spi flash. However, when
    loading romstage from verstage the romstage is
    execute-in-place so it's unnecessary to write over a read-only
    media -- not to mention writing to read-only memory is wrong
    to begin with.
    
    BUG=chrome-os-partner:44827
    BRANCH=None
    TEST=Built and booted glados. Noted reduction of 20ms when
         loading romstage.
    
    Change-Id: I7cd399302a3925a05fbce82600b4c50ea66a0fcb
    Signed-off-by: Aaron Durbin <adurbin at chromium.org>
    Reviewed-on: http://review.coreboot.org/11823
    Tested-by: build bot (Jenkins)
    Reviewed-by: Patrick Georgi <pgeorgi at google.com>


See http://review.coreboot.org/11823 for details.

-gerrit



More information about the coreboot-gerrit mailing list