[coreboot-gerrit] New patch to review for coreboot: google/auron: avoid echo -n

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Sun Oct 11 15:25:10 CEST 2015


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11868

-gerrit

commit b80873991ee4fde3e15a76f2fca348fa3adbf673
Author: Patrick Georgi <patrick at georgi-clan.de>
Date:   Sun Oct 11 15:24:49 2015 +0200

    google/auron: avoid echo -n
    
    It's nasty. Use POSIX printf(1) instead.
    
    Change-Id: Ia83e3c7dd31a18aac5621f418af76b3f7101cee1
    Signed-off-by: Patrick Georgi <patrick at georgi-clan.de>
---
 src/mainboard/google/auron/spd/Makefile.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mainboard/google/auron/spd/Makefile.inc b/src/mainboard/google/auron/spd/Makefile.inc
index 7b0292d..5ac90b6 100644
--- a/src/mainboard/google/auron/spd/Makefile.inc
+++ b/src/mainboard/google/auron/spd/Makefile.inc
@@ -45,7 +45,7 @@ SPD_DEPS := $(foreach f, $(SPD_SOURCES), src/mainboard/$(MAINBOARDDIR)/spd/$(f).
 $(SPD_BIN): $(SPD_DEPS)
 	for f in $+; \
 	  do for c in $$(cat $$f | grep -v ^#); \
-	    do echo -e -n "\\x$$c"; \
+	    do printf "\\x$$c"; \
 	  done; \
 	done > $@
 



More information about the coreboot-gerrit mailing list