[coreboot-gerrit] Patch set updated for coreboot: Kconfig: Hide BOARD_ID_MANUAL.

Vladimir Serbinenko (phcoder@gmail.com) gerrit at coreboot.org
Sun Oct 11 12:19:08 CEST 2015


Vladimir Serbinenko (phcoder at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10379

-gerrit

commit 7086adfca03e71b2ced927cdd3e705c652f54e42
Author: Vladimir Serbinenko <phcoder at gmail.com>
Date:   Sat May 30 22:47:22 2015 +0200

    Kconfig: Hide BOARD_ID_MANUAL.
    
    board_id() returns an integer which is platform-specific. 0 for one port
    is different from 0 for another port. So there is no default board_id()
    and hence enabling it on boards other than urara would cause build failure.
    Not enabling it on urara or just setting id to "(none)" as is default results
    in board_id() = 0 which means urara and an error message on console.
    
    Change-Id: I94618f36a75e7505984bbec345a31fe0fa9cc867
    Signed-off-by: Vladimir Serbinenko <phcoder at gmail.com>
---
 src/Kconfig                        | 2 +-
 src/mainboard/google/urara/Kconfig | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/Kconfig b/src/Kconfig
index bab05f2..9ac6ec6 100644
--- a/src/Kconfig
+++ b/src/Kconfig
@@ -302,7 +302,7 @@ config BOARD_ID_AUTO
 	  (ie. GPIO) select this configuration option.
 
 config BOARD_ID_MANUAL
-	bool "Add board ID file to CBFS"
+	bool
 	default n
 	depends on !BOARD_ID_AUTO
 	help
diff --git a/src/mainboard/google/urara/Kconfig b/src/mainboard/google/urara/Kconfig
index a43d84e..eb7e09f 100644
--- a/src/mainboard/google/urara/Kconfig
+++ b/src/mainboard/google/urara/Kconfig
@@ -29,6 +29,7 @@ config BOARD_SPECIFIC_OPTIONS
 	select CPU_IMGTEC_PISTACHIO
 	select COMMON_CBFS_SPI_WRAPPER
 	select SPI_FLASH
+	select BOARD_ID_MANUAL
 
 config MAINBOARD_DIR
 	string



More information about the coreboot-gerrit mailing list