[coreboot-gerrit] Patch set updated for coreboot: mb/lenovo: reserve century byte

Alexander Couzens (lynxis@fe80.eu) gerrit at coreboot.org
Sat Oct 10 16:58:18 CEST 2015


Alexander Couzens (lynxis at fe80.eu) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11853

-gerrit

commit 0ab135f724e3ce03daca5e7e6a483f9dfe4cdd68
Author: Alexander Couzens <lynxis at fe80.eu>
Date:   Sat Oct 10 16:04:59 2015 +0200

    mb/lenovo: reserve century byte
    
    The century byte is used by most RTC (default 0x32 at nvram).
    Even the century byte can disabled via ACPI it's more safe to reserve
    it's space. Because some RTC will act with that byte anyhow.
    Some OS overwrite it when syncronize the RTC.
    
    Change-Id: I078c0c57215ccb925afa85b9d067f15268801ec9
    Signed-off-by: Alexander Couzens <lynxis at fe80.eu>
---
 src/mainboard/lenovo/g505s/cmos.layout |  3 ++-
 src/mainboard/lenovo/t400/cmos.layout  |  6 +++---
 src/mainboard/lenovo/t420s/cmos.layout |  6 ++++--
 src/mainboard/lenovo/t430s/cmos.layout |  5 +++--
 src/mainboard/lenovo/t520/cmos.layout  |  5 +++--
 src/mainboard/lenovo/t530/cmos.layout  |  6 ++++--
 src/mainboard/lenovo/t60/cmos.layout   | 10 ++++++----
 src/mainboard/lenovo/x200/cmos.layout  |  7 +++----
 src/mainboard/lenovo/x201/cmos.layout  |  4 +++-
 src/mainboard/lenovo/x220/cmos.layout  |  3 ++-
 src/mainboard/lenovo/x230/cmos.layout  |  6 ++++--
 src/mainboard/lenovo/x60/cmos.layout   | 10 ++++++----
 12 files changed, 43 insertions(+), 28 deletions(-)

diff --git a/src/mainboard/lenovo/g505s/cmos.layout b/src/mainboard/lenovo/g505s/cmos.layout
index 50750a8..6e6cf0b 100644
--- a/src/mainboard/lenovo/g505s/cmos.layout
+++ b/src/mainboard/lenovo/g505s/cmos.layout
@@ -29,7 +29,8 @@ entries
 396          1       e       1        interleave_chip_selects
 397          2       e       8        max_mem_clock
 399          1       e       2        multi_core
-400          1       e       1        power_on_after_fail
+#400         8       r       8        reserved for century byte
+408          1       e       1        power_on_after_fail
 412          4       e       6        debug_level
 440          4       e       9        slow_cpu
 444          1       e       1        nmi
diff --git a/src/mainboard/lenovo/t400/cmos.layout b/src/mainboard/lenovo/t400/cmos.layout
index 2dc91bf..aa46c47 100644
--- a/src/mainboard/lenovo/t400/cmos.layout
+++ b/src/mainboard/lenovo/t400/cmos.layout
@@ -58,8 +58,7 @@ entries
 395           4       e       6        debug_level
 #399          1       r       0        unused
 
-# coreboot config options: EC
-400         8       h       0        volume
+#400          8       r       0        reserved for century byte
 
 # coreboot config options: southbridge
 408         1       e       10        sata_mode
@@ -85,7 +84,8 @@ entries
 # coreboot config options: northbridge
 941         3       e       11       gfx_uma_size
 
-#944          2       r       0        unused
+# coreboot config options: EC
+944         8       h       0        volume
 
 # coreboot config options: check sums
 984          16       h       0        check_sum
diff --git a/src/mainboard/lenovo/t420s/cmos.layout b/src/mainboard/lenovo/t420s/cmos.layout
index 77c0a11..74ef730 100644
--- a/src/mainboard/lenovo/t420s/cmos.layout
+++ b/src/mainboard/lenovo/t420s/cmos.layout
@@ -57,7 +57,7 @@ entries
 395          4       e       6        debug_level
 #399          1       r       0        unused
 
-400          8       h       0        volume
+#400         8       r       0        reserved for century byte
 
 # coreboot config options: southbridge
 408          1       e       1        nmi
@@ -82,7 +82,9 @@ entries
 
 # coreboot config options: northbridge
 432          3       e       11       gfx_uma_size
-#435          549     r       0        unused
+#435         5       r       0        unused
+
+440          8       h       0        volume
 
 # SandyBridge MRC Scrambler Seed values
 896          32      r       0        mrc_scrambler_seed
diff --git a/src/mainboard/lenovo/t430s/cmos.layout b/src/mainboard/lenovo/t430s/cmos.layout
index f546d45..d796b3e 100644
--- a/src/mainboard/lenovo/t430s/cmos.layout
+++ b/src/mainboard/lenovo/t430s/cmos.layout
@@ -57,7 +57,7 @@ entries
 395          4       e       6        debug_level
 #399          1       r       0        unused
 
-400          8       h       0        volume
+#400         8       r       0        reserved for century byte
 
 # coreboot config options: southbridge
 408          1       e       1        nmi
@@ -82,7 +82,8 @@ entries
 
 # coreboot config options: northbridge
 432          3       e       11       gfx_uma_size
-#435          549     r       0        unused
+#435         5       r       0        unused
+440          8       h       0        volume
 
 # SandyBridge MRC Scrambler Seed values
 896          32      r       0        mrc_scrambler_seed
diff --git a/src/mainboard/lenovo/t520/cmos.layout b/src/mainboard/lenovo/t520/cmos.layout
index 2478542..e9512c1 100644
--- a/src/mainboard/lenovo/t520/cmos.layout
+++ b/src/mainboard/lenovo/t520/cmos.layout
@@ -57,7 +57,7 @@ entries
 395          4       e       6        debug_level
 #399          1       r       0        unused
 
-400          8       h       0        volume
+#400         8       r       0        reserved for century byte
 
 # coreboot config options: southbridge
 408          1       e       1        nmi
@@ -82,7 +82,8 @@ entries
 
 # coreboot config options: northbridge
 432         3        e      11        gfx_uma_size
-#435        549       r       0        unused
+#435        5        r       0        unused
+440         8        h       0        volume
 
 # SandyBridge MRC Scrambler Seed values
 896         32        r       0        mrc_scrambler_seed
diff --git a/src/mainboard/lenovo/t530/cmos.layout b/src/mainboard/lenovo/t530/cmos.layout
index 2478542..57ef343 100644
--- a/src/mainboard/lenovo/t530/cmos.layout
+++ b/src/mainboard/lenovo/t530/cmos.layout
@@ -57,7 +57,7 @@ entries
 395          4       e       6        debug_level
 #399          1       r       0        unused
 
-400          8       h       0        volume
+#400         8       r       0        reserved for century byte
 
 # coreboot config options: southbridge
 408          1       e       1        nmi
@@ -82,7 +82,9 @@ entries
 
 # coreboot config options: northbridge
 432         3        e      11        gfx_uma_size
-#435        549       r       0        unused
+#435        5        r       0        unused
+
+440          8       h       0        volume
 
 # SandyBridge MRC Scrambler Seed values
 896         32        r       0        mrc_scrambler_seed
diff --git a/src/mainboard/lenovo/t60/cmos.layout b/src/mainboard/lenovo/t60/cmos.layout
index 5d0e206..ba2f974 100644
--- a/src/mainboard/lenovo/t60/cmos.layout
+++ b/src/mainboard/lenovo/t60/cmos.layout
@@ -57,9 +57,7 @@ entries
 395          4       e       6        debug_level
 #399          1       r       0        unused
 
-# coreboot config options: cpu
-400          1       e       2        hyper_threading
-#401          7       r       0        unused
+#400         8       r       0        reserved for century byte
 
 # coreboot config options: southbridge
 408          1       e       1        nmi
@@ -71,7 +69,11 @@ entries
 928          8       h       0        boot_default
 936          1       e       8        cmos_defaults_loaded
 937          1       e       1        lpt
-#938         46       r       0        unused
+#938         7       r       0        unused
+
+# coreboot config options: cpu
+944          1       e       2        hyper_threading
+#945         7       r       0        unused
 
 # coreboot config options: check sums
 984         16       h       0        check_sum
diff --git a/src/mainboard/lenovo/x200/cmos.layout b/src/mainboard/lenovo/x200/cmos.layout
index 39ced9b..987e101 100644
--- a/src/mainboard/lenovo/x200/cmos.layout
+++ b/src/mainboard/lenovo/x200/cmos.layout
@@ -58,8 +58,7 @@ entries
 395           4       e       6        debug_level
 #399          1       r       0        unused
 
-# coreboot config options: EC
-400         8       h       0        volume
+#400          8       r       0        reserved for century byte
 
 # coreboot config options: southbridge
 408         1       e       10        sata_mode
@@ -84,8 +83,8 @@ entries
 
 # coreboot config options: northbridge
 941         3       e       11       gfx_uma_size
-
-#944          2       r       0        unused
+#944        5       r       0        unused
+948         8       h       0        volume
 
 # coreboot config options: check sums
 984          16       h       0        check_sum
diff --git a/src/mainboard/lenovo/x201/cmos.layout b/src/mainboard/lenovo/x201/cmos.layout
index e59dc2b..71240cc 100644
--- a/src/mainboard/lenovo/x201/cmos.layout
+++ b/src/mainboard/lenovo/x201/cmos.layout
@@ -57,7 +57,7 @@ entries
 395          4       e       6        debug_level
 #399         1       r       0        unused
 
-400          8       h       0        volume
+#400         8       r       0        reserved for century byte
 
 # coreboot config options: southbridge
 408          1       e       1        nmi
@@ -80,6 +80,8 @@ entries
 
 # coreboot config options: northbridge
 424         3       e       10       gfx_uma_size
+#427         1       r       0       unused
+432          8       h       0        volume
 
 #427        557     r       0        unused
 
diff --git a/src/mainboard/lenovo/x220/cmos.layout b/src/mainboard/lenovo/x220/cmos.layout
index 3b44799..dd2d743 100644
--- a/src/mainboard/lenovo/x220/cmos.layout
+++ b/src/mainboard/lenovo/x220/cmos.layout
@@ -57,7 +57,7 @@ entries
 395          4       e       6        debug_level
 #399          1       r       0        unused
 
-400          8       h       0        volume
+#400         8       r       0        reserved for century byte
 
 # coreboot config options: southbridge
 408          1       e       1        nmi
@@ -83,6 +83,7 @@ entries
 # coreboot config options: northbridge
 432         3        e      11        gfx_uma_size
 #435        549       r       0        unused
+440         8       h       0        volume
 
 # SandyBridge MRC Scrambler Seed values
 896         32        r       0        mrc_scrambler_seed
diff --git a/src/mainboard/lenovo/x230/cmos.layout b/src/mainboard/lenovo/x230/cmos.layout
index 7ae370f..b143d76 100644
--- a/src/mainboard/lenovo/x230/cmos.layout
+++ b/src/mainboard/lenovo/x230/cmos.layout
@@ -57,7 +57,7 @@ entries
 395          4       e       6        debug_level
 #399          1       r       0        unused
 
-400          8       h       0        volume
+#400         8       r       0        reserved for century byte
 
 # coreboot config options: southbridge
 408          1       e       1        nmi
@@ -82,7 +82,9 @@ entries
 
 # coreboot config options: northbridge
 432         3        e      11        gfx_uma_size
-#435        549       r       0        unused
+#435        5        r       0        unused
+
+440          8       h       0        volume
 
 # SandyBridge MRC Scrambler Seed values
 896         32        r       0        mrc_scrambler_seed
diff --git a/src/mainboard/lenovo/x60/cmos.layout b/src/mainboard/lenovo/x60/cmos.layout
index a39ed72..fa24ee6 100644
--- a/src/mainboard/lenovo/x60/cmos.layout
+++ b/src/mainboard/lenovo/x60/cmos.layout
@@ -57,9 +57,7 @@ entries
 395          4       e       6        debug_level
 #399          1       r       0        unused
 
-# coreboot config options: cpu
-400          1       e       2        hyper_threading
-#401          7       r       0        unused
+#400         8       r       0        reserved for century byte
 
 # coreboot config options: southbridge
 408          1       e       1        nmi
@@ -71,7 +69,11 @@ entries
 928          8       h       0        boot_default
 936          1       e       8        cmos_defaults_loaded
 937          1       e       1        lpt
-#938         46       r       0        unused
+#938         7       r       0        unused
+
+# coreboot config options: cpu
+944          1       e       2        hyper_threading
+#945         7       r       0        unused
 
 # coreboot config options: check sums
 984         16       h       0        check_sum



More information about the coreboot-gerrit mailing list