[coreboot-gerrit] Patch set updated for coreboot: cbfstool: allow printable characters in image name
Andrey Petrov (andrey.petrov@intel.com)
gerrit at coreboot.org
Thu Oct 8 18:01:23 CET 2015
Andrey Petrov (andrey.petrov at intel.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11807
-gerrit
commit 854a6be355518b6eff86d5571da9366591a285ae
Author: Andrey Petrov <andrey.petrov at intel.com>
Date: Wed Oct 7 13:37:49 2015 -0700
cbfstool: allow printable characters in image name
Currently cbfstool would reject non-alpanumeric characters in
image names. Underscore is not alphanumeric and is used in some
default fmaps. This change allows image names to contain all
"printable" characters.
Change-Id: I6ba2b581d5623f5b028149ece0169892ea63fd04
Signed-off-by: Andrey Petrov <andrey.petrov at intel.com>
---
util/cbfstool/flashmap/fmap.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/util/cbfstool/flashmap/fmap.c b/util/cbfstool/flashmap/fmap.c
index f803d6c..24181d0 100644
--- a/util/cbfstool/flashmap/fmap.c
+++ b/util/cbfstool/flashmap/fmap.c
@@ -89,12 +89,12 @@ static int is_valid_fmap(const struct fmap *fmap)
while (i < FMAP_STRLEN) {
if (fmap->name[i] == 0)
break;
- if (!isalnum(fmap->name[i]))
+ if (!isgraph(fmap->name[i]))
return 0;
if (i == FMAP_STRLEN - 1) {
- /* name is specified to be null terminated. We didn't
- * break in the 0 test, we didn't fail on the alnum
- * test, so we're seeing FMAP_STRLEN alphanumerical
+ /* name is specified to be null terminated single-word string
+ * without spaces. We did not break in the 0 test, we know it
+ * is a printable spaceless string but we're seeing FMAP_STRLEN
* symbols, which is one too many.
*/
return 0;
More information about the coreboot-gerrit
mailing list