[coreboot-gerrit] Patch merged into coreboot/master: arch/x86: Link walkcbfs.S instead on including it in bootblock.S

gerrit at coreboot.org gerrit at coreboot.org
Thu Oct 8 16:44:40 CET 2015


the following patch was just integrated into master:
commit c46a39237a18bdd4de826bce10ae89be718f9289
Author: Alexandru Gagniuc <mr.nuke.me at gmail.com>
Date:   Fri Oct 2 16:17:41 2015 -0700

    arch/x86: Link walkcbfs.S instead on including it in bootblock.S
    
    The code flow doesn't fall through to walkcbfs, as it does in the rest
    of bootblock.S. Instead, walkcbfs is called (albeit via a jmp). The
    linker cannot know this when walkcbfs.S is included directly.
    
    When we use a CAR bootblock, we lose several hundred bytes because
    walkcbfs is not garbage-collected, yet it isn't used. This problem
    is solved by assembling walkcbfs.S separately, and linking it.
    
    Change-Id: Ib3a976db09b9ff270b7677cb4f9db80b0b025e22
    Signed-off-by: Alexandru Gagniuc <mr.nuke.me at gmail.com>
    Reviewed-on: http://review.coreboot.org/11785
    Tested-by: build bot (Jenkins)
    Reviewed-by: Patrick Georgi <pgeorgi at google.com>


See http://review.coreboot.org/11785 for details.

-gerrit



More information about the coreboot-gerrit mailing list