[coreboot-gerrit] Patch set updated for coreboot: fsp1_0: Fix broken logic when searching for FSP
Werner Zeh (werner.zeh@siemens.com)
gerrit at coreboot.org
Wed Oct 7 13:11:49 CET 2015
Werner Zeh (werner.zeh at siemens.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11806
-gerrit
commit 92d0c686f8d6e5785b351fd16f65cfd4075476e2
Author: Werner Zeh <werner.zeh at siemens.com>
Date: Wed Oct 7 13:34:39 2015 +0200
fsp1_0: Fix broken logic when searching for FSP
Commit 47818b4d6017b89e398cfbc86e3c437e0f81cfdf
(fsp/cache_as_ram.inc and boards: Fix incorrect usage of POST_IO)
breaks the logic which decides whether FSP
could be found or not in cache_as_ram.inc.
Fix the error by inverting the logic of the test.
TEST=Bootet mc_tcu3 board
Change-Id: I993d3422ac406d204a53e4dc890210fb9a52469d
Signed-off-by: Werner Zeh <werner.zeh at siemens.com>
---
src/drivers/intel/fsp1_0/cache_as_ram.inc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/drivers/intel/fsp1_0/cache_as_ram.inc b/src/drivers/intel/fsp1_0/cache_as_ram.inc
index 91cfb88..d1167b1 100644
--- a/src/drivers/intel/fsp1_0/cache_as_ram.inc
+++ b/src/drivers/intel/fsp1_0/cache_as_ram.inc
@@ -51,8 +51,8 @@ find_fsp_ret:
/* Save the FSP location */
mov %eax, %ebp
cmp $CONFIG_FSP_LOC, %eax
- je find_fsp_ok
- add $0xb0, %eax
+ jae find_fsp_ok
+ mov $0xb0, %eax
jmp .Lhlt
find_fsp_ok:
More information about the coreboot-gerrit
mailing list