[coreboot-gerrit] Patch merged into coreboot/master: fsp/cache_as_ram.inc and boards: Fix incorrect usage of POST_IO

gerrit at coreboot.org gerrit at coreboot.org
Tue Oct 6 04:09:51 CET 2015


the following patch was just integrated into master:
commit 47818b4d6017b89e398cfbc86e3c437e0f81cfdf
Author: Alexandru Gagniuc <mr.nuke.me at gmail.com>
Date:   Wed Feb 18 14:51:41 2015 -0600

    fsp/cache_as_ram.inc and boards: Fix incorrect usage of POST_IO
    
    POST_IO is a user-visible config bool. fsp_1_0/cache_as_ram.inc made a
    mess of it, by forcing a build-time error when CONFIG_POST_IO was not
    being set. fsp 1.0 boards ended 'select'ing this in their Kconfig.
    
    Refactor fsp/cache_as_ram.inc handling of POST codes, and remove the
    "select POST_IO" from boards that have it. Instead of implementing an
    ad-hoc changing post code display and a delay based on port 0xed, just
    encode the FSP failure code in the POST code. Since FSP failure codes
    are > 16, we can encode the failure code in the lower nibble, and theirfailing function in the upper nibble.
    
    Change-Id: Iaa3e6533e8406b16ec0689abd704984d79293952
    Signed-off-by: Alexandru Gagniuc <mr.nuke.me at gmail.com>
    Reviewed-on: http://review.coreboot.org/8485
    Tested-by: build bot (Jenkins)
    Reviewed-by: Werner Zeh <werner.zeh at siemens.com>


See http://review.coreboot.org/8485 for details.

-gerrit



More information about the coreboot-gerrit mailing list