[coreboot-gerrit] Patch set updated for coreboot: nb/intel/sandybridge/raminit: Add edge write discovery check

Alexandru Gagniuc (mr.nuke.me@gmail.com) gerrit at coreboot.org
Sat Oct 3 23:04:49 CET 2015


Alexandru Gagniuc (mr.nuke.me at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11247

-gerrit

commit 623c29b4ce72bcd318cbcadcd2b3da5992961a24
Author: Patrick Rudolph <siro at das-labor.org>
Date:   Sun Aug 16 17:06:30 2015 +0200

    nb/intel/sandybridge/raminit: Add edge write discovery check
    
    Make sure edge write test results are sane.
    Check rn.all to make sure rn.start and rn.end are valid.
    Most likely the following test is going to fail on the same
    rank anyway.
    
    Change-Id: Ifa601406e6c74ceb8d70063be5ce1bf6bc512c18
    Signed-off-by: Patrick Rudolph <siro at das-labor.org>
    Signed-off-by: Alexandru Gagniuc <mr.nuke.me at gmail.com>
---
 src/northbridge/intel/sandybridge/raminit.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/northbridge/intel/sandybridge/raminit.c b/src/northbridge/intel/sandybridge/raminit.c
index 9df102a..76f62a6 100644
--- a/src/northbridge/intel/sandybridge/raminit.c
+++ b/src/northbridge/intel/sandybridge/raminit.c
@@ -3130,6 +3130,8 @@ static void discover_edges_write_real(ramctr_timing * ctrl, int channel,
 				upper[lane] =
 					min(rn.end - ctrl->edge_offset[i], upper[lane]);
 				edges[lane] = (lower[lane] + upper[lane]) / 2;
+				if (rn.all || (lower[lane] > upper[lane]))
+					die("edge write discovery failed");
 
 			}
 		}



More information about the coreboot-gerrit mailing list