[coreboot-gerrit] Patch set updated for coreboot: drivers/uart/Kconfig: Select 8250 mem when 8250 mem32 is enabled

Alexandru Gagniuc (mr.nuke.me@gmail.com) gerrit at coreboot.org
Sat Oct 3 04:36:36 CET 2015


Alexandru Gagniuc (mr.nuke.me at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11786

-gerrit

commit b281d4ff65be44c7dfcd5f433679158a5a65f0c1
Author: Alexandru Gagniuc <mr.nuke.me at gmail.com>
Date:   Fri Oct 2 17:01:22 2015 -0700

    drivers/uart/Kconfig: Select 8250 mem when 8250 mem32 is enabled
    
    Users of DRIVERS_UART_8250MEM_32 would have to also select
    DRIVERS_UART_8250MEM to avoid missing Kconfig dependencies. Instead,
    do what the OXPCIE driver dies and select the appropriate options.
    
    Change-Id: I40d93df024fcb3a9ad6dc51d6a5966e7b1b6c07f
    Signed-off-by: Alexandru Gagniuc <mr.nuke.me at gmail.com>
---
 src/drivers/uart/Kconfig      | 2 +-
 src/soc/intel/skylake/Kconfig | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/drivers/uart/Kconfig b/src/drivers/uart/Kconfig
index cbfd479..f4ad011 100644
--- a/src/drivers/uart/Kconfig
+++ b/src/drivers/uart/Kconfig
@@ -20,7 +20,7 @@ config DRIVERS_UART_8250MEM
 config DRIVERS_UART_8250MEM_32
 	bool
 	default n
-	depends on DRIVERS_UART_8250MEM
+	select DRIVERS_UART_8250MEM
 
 config HAVE_UART_SPECIAL
 	bool
diff --git a/src/soc/intel/skylake/Kconfig b/src/soc/intel/skylake/Kconfig
index ae50bd2..bf747d4 100644
--- a/src/soc/intel/skylake/Kconfig
+++ b/src/soc/intel/skylake/Kconfig
@@ -141,7 +141,6 @@ config UART_DEBUG
 	default n
 	select CONSOLE_SERIAL
 	select DRIVERS_UART
-	select DRIVERS_UART_8250MEM
 	select DRIVERS_UART_8250MEM_32
 
 config CHIPSET_BOOTBLOCK_INCLUDE



More information about the coreboot-gerrit mailing list