[coreboot-gerrit] Patch set updated for coreboot: x86/smm: don't hide harmless declarations

Damien Zammit (damien@zamaudio.com) gerrit at coreboot.org
Sat Nov 28 12:55:42 CET 2015


Damien Zammit (damien at zamaudio.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/12565

-gerrit

commit b6a92a93f9a9ebb7a6d9d333edc022d576246c39
Author: Patrick Georgi <patrick at georgi-clan.de>
Date:   Sat Nov 28 12:17:32 2015 +0100

    x86/smm: don't hide harmless declarations
    
    Hiding them requires #if CONFIG_HAVE_SMI_HANDLER instead of
    if (IS_ENABLED(CONFIG_HAVE_SMI_HANDLER))
    
    Change-Id: Ib874cd98e195ad7437d05be1696004b29bf97a66
    Signed-off-by: Patrick Georgi <patrick at georgi-clan.de>
---
 src/include/cpu/cpu.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/include/cpu/cpu.h b/src/include/cpu/cpu.h
index 28431c0..8db8085 100644
--- a/src/include/cpu/cpu.h
+++ b/src/include/cpu/cpu.h
@@ -9,11 +9,9 @@ struct bus;
 void initialize_cpus(struct bus *cpu_bus);
 void asmlinkage secondary_cpu_init(unsigned int cpu_index);
 
-#if CONFIG_HAVE_SMI_HANDLER
 void smm_init(void);
 void smm_lock(void);
 void smm_setup_structures(void *gnvs, void *tcg, void *smi1);
-#endif
 
 #define __cpu_driver __attribute__ ((used,__section__(".rodata.cpu_driver")))
 #ifndef __SIMPLE_DEVICE__



More information about the coreboot-gerrit mailing list