[coreboot-gerrit] New patch to review for coreboot: [DO_NOT_SUBMIT] amd/pi/00630F01: add HT3 Kconfig option

[Martin Roth (martinroth@google.com)]

Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/12556

-gerrit

commit 5ca64f512903c562d26538b9a0fde8c9b2a77f81
Author: Martin Roth <martinroth at google.com>
Date:   Thu Nov 26 21:51:03 2015 -0700

    [DO_NOT_SUBMIT] amd/pi/00630F01: add HT3 Kconfig option
    
    In northbridge.c, the Kconfig option _HT3_SUPPORT is being used.
    Unfortunately, until this patch, that option didn't esixt, so the
    value was always set to 4.
    
    Should the kconfig option be added?  What's the help text.
    Should it default to on or off.
    Should this be done in a different fashion?  Can HT3 support
    be detected?
    Should this just always be set to 4, and the HT3 support be
    removed?
    
    Change-Id: I2682d3b620e2cee613c7421622a8c79db5ba3a86
    Signed-off-by: Martin Roth <martinroth at google.com>
---
 src/northbridge/amd/pi/00630F01/Kconfig       | 3 +++
 src/northbridge/amd/pi/00630F01/northbridge.c | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/northbridge/amd/pi/00630F01/Kconfig b/src/northbridge/amd/pi/00630F01/Kconfig
index 293b12d..dbcb149 100644
--- a/src/northbridge/amd/pi/00630F01/Kconfig
+++ b/src/northbridge/amd/pi/00630F01/Kconfig
@@ -34,6 +34,9 @@ config MMCONF_BUS_NUMBER
 	int
 	default 64
 
+config HT3_SUPPORT
+	bool "Enable HT3 support"
+
 config VGA_BIOS_ID
 	string
 	default "1002,1304"
diff --git a/src/northbridge/amd/pi/00630F01/northbridge.c b/src/northbridge/amd/pi/00630F01/northbridge.c
index 9f55874..72a0b64 100644
--- a/src/northbridge/amd/pi/00630F01/northbridge.c
+++ b/src/northbridge/amd/pi/00630F01/northbridge.c
@@ -1040,7 +1040,7 @@ static void cpu_bus_scan(device_t dev)
 			 * otherwise the device under it will not be scanned
 			 */
 			int linknum;
-#if IS_ENABLED(CONFIG_HT3_SUPPORT)
+#if IS_ENABLED(CONFIG_HT3_SUPPORT) /* CONFIG_HT3_SUPPORT used here */
 			linknum = 8;
 #else
 			linknum = 4;