[coreboot-gerrit] Patch set updated for coreboot: Makefile: Individualize help targets & set as non-compile targets

Martin Roth (martinroth@google.com) gerrit at coreboot.org
Thu Nov 26 01:04:49 CET 2015


Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/12542

-gerrit

commit d22ac163f98e93a260ebde48f0e53da85b4e6f00
Author: Martin Roth <martinroth at google.com>
Date:   Wed Nov 25 12:50:25 2015 -0700

    Makefile: Individualize help targets & set as non-compile targets
    
    - Including the help targets in the list of NOCOMPILE targets means they
    can run even if the toolchain is mucked up.  Since they contain info on
    building the toolchin, this is useful.
    - Separate the three current parts of the help target into individual
    components: help_coreboot, help_toolchain, and help_kconfig.  This is
    mostly for the help_toolchin target which will be printed out by
    toolchain.inc.
    
    Change-Id: I365d95fd63e22bddd122fb1fede6f04270e03d63
    Signed-off-by: Martin Roth <martinroth at google.com>
---
 Makefile              | 6 +++---
 Makefile.inc          | 4 ++--
 util/kconfig/Makefile | 4 ++--
 3 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/Makefile b/Makefile
index 05da7be..8eef124 100644
--- a/Makefile
+++ b/Makefile
@@ -93,8 +93,8 @@ DOXYGEN_OUTPUT_DIR := doxygen
 
 all: real-all
 
-help_coreboot help::
-	@echo  '*** coreboot platform targets ***'
+help::
+	@echo  '*** coreboot platform ***'
 	@echo  '  Use "make [target] V=1" for extra build debug information'
 	@echo  '  all                   - Build coreboot'
 	@echo  '  clean                 - Remove coreboot build artifacts'
@@ -121,7 +121,7 @@ ifeq ($(strip $(HAVE_DOTCONFIG)),)
 NOCOMPILE:=1
 endif
 ifneq ($(MAKECMDGOALS),)
-ifneq ($(filter %config %clean cross% clang iasl lint% what-jenkins-does,$(MAKECMDGOALS)),)
+ifneq ($(filter %config %clean cross% clang iasl lint% help% what-jenkins-does,$(MAKECMDGOALS)),)
 NOCOMPILE:=1
 endif
 ifeq ($(MAKECMDGOALS), %clean)
diff --git a/Makefile.inc b/Makefile.inc
index a1c882b..8caf36b 100644
--- a/Makefile.inc
+++ b/Makefile.inc
@@ -446,8 +446,8 @@ gitconfig:
 	git config remote.origin.push HEAD:refs/for/master
 	(git config --global user.name >/dev/null && git config --global user.email >/dev/null) || (printf 'Please configure your name and email in git:\n\n git config --global user.name "Your Name Comes Here"\n git config --global user.email your.email at example.com\n'; exit 1)
 
-help::
-	@echo  '*** Toolchain ***'
+help_toolchain help::
+	@echo  '*** Toolchain targets ***'
 	@echo  '  crossgcc        - Build coreboot cross-compilers for all platforms'
 	@echo  '  crosstools      - Build coreboot cross-compiler and GDB for all platforms'
 	@echo  '  crossgcc-clean  - Remove all built coreboot cross-compilers'
diff --git a/util/kconfig/Makefile b/util/kconfig/Makefile
index a468125..cec676b 100644
--- a/util/kconfig/Makefile
+++ b/util/kconfig/Makefile
@@ -104,8 +104,8 @@ olddefconfig: $(objk)/conf
 	$< --defconfig=configs/$@ $(Kconfig)
 
 # Help text used by make help
-help::
-	@echo  '*** Kconfig Help ***'
+help_kconfig help::
+	@echo  '*** Kconfig Targets ***'
 	@echo  '  config	  - Update current config utilising a line-oriented program'
 	@echo  '  nconfig         - Update current config utilising a ncurses menu based program'
 	@echo  '  menuconfig	  - Update current config utilising a menu based program'



More information about the coreboot-gerrit mailing list