[coreboot-gerrit] New patch to review for coreboot: asrock/e350m1: Fix IASL warnings

[Martin Roth (martinroth@google.com)]

Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/12544

-gerrit

commit de24276ed911bb059d61165bcfa01af369fd7cc6
Author: Martin Roth <martinroth at google.com>
Date:   Wed Nov 25 13:11:44 2015 -0700

    asrock/e350m1: Fix IASL warnings
    
    Both of these 'fixes' need to be looked at further, and fixed in a LOT
    of places however we decide to fix them.
    
    *** Method Local is set but never used ***
    I added a load of another value into Local1, doing something similar
    to the _OSI example from the ACPI spec.  This fixes the IASL warning,
    although it's a kludge.  A better solution might be if IASL had a
    way to disable the warning in that specific area.  I can disable the
    warning completely from the command line, but I don't want to do that.
    
    However:  This code is never even run, because we set the assumption
    that we're running linux, and bail out immediately.  I don't even know
    if the value is used anywhere.
    
    Fixes IASL warning:
    dsdt.aml 22:   if(CondRefOf(\_OSI,Local1))
    Warning 3144 -                    ^ Method Local is set but never used
    (Local1)
    
    ***Duplicate value in list ***
    I'm not positive of what the intention here was.  The comment says that
    we're clearing PciExpWakeStatus though, so let's actually clear it.
    
    Since this wasn't actually doing anything before, it might be better
    if the line were just deleted.
    
    Fixes IASL warning:
    dsdt.aml   1396:  Store(PWST, PWST)
    Warning  3023 -                 ^ Duplicate value in list
    (Source is the same as Target)
    
    Change-Id: I055de90ee5d44af8b7cbb5af02a82f7109638a18
    Signed-off-by: Martin Roth <martinroth at google.com>
---
 src/mainboard/asrock/e350m1/acpi/mainboard.asl | 3 ++-
 src/mainboard/asrock/e350m1/acpi/sleep.asl     | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/mainboard/asrock/e350m1/acpi/mainboard.asl b/src/mainboard/asrock/e350m1/acpi/mainboard.asl
index 57a414e..ca98bc0 100644
--- a/src/mainboard/asrock/e350m1/acpi/mainboard.asl
+++ b/src/mainboard/asrock/e350m1/acpi/mainboard.asl
@@ -43,7 +43,8 @@ Scope(\_SB) {
 				Store(2, OSVR)
 			}
 		} else {
-			If(WCMP(\_OS,"Linux")) {
+			Store(\_OS, Local1)
+			If(LEqual(Local1,"Linux")) {
 				Store(3, OSVR)				/* Linux */
 			} Else {
 				Store(4, OSVR)				/* Gotta be WinCE */
diff --git a/src/mainboard/asrock/e350m1/acpi/sleep.asl b/src/mainboard/asrock/e350m1/acpi/sleep.asl
index e043ee2..8cbc5e3 100644
--- a/src/mainboard/asrock/e350m1/acpi/sleep.asl
+++ b/src/mainboard/asrock/e350m1/acpi/sleep.asl
@@ -104,7 +104,7 @@ Method(\_WAK, 1) {
 	}
 
 	/* Arbitrarily clear PciExpWakeStatus */
-	Store(PWST, PWST)
+	Store(Zero, PWST)
 
 	/* if(DeRefOf(Index(WKST,0))) {
 	*	Store(0, Index(WKST,1))