[coreboot-gerrit] New patch to review for coreboot: build system: break overly long lines into logical units

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Wed Nov 25 19:29:02 CET 2015


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/12540

-gerrit

commit 4c2a6642acb5164d9df4aa2a397566fd84c30f89
Author: Patrick Georgi <pgeorgi at chromium.org>
Date:   Wed Nov 25 19:17:42 2015 +0100

    build system: break overly long lines into logical units
    
    Change-Id: I37b716acb305a79614cea184f57b8488111eab7a
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
---
 Makefile.inc | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/Makefile.inc b/Makefile.inc
index 3d0f0fa..457db5e 100644
--- a/Makefile.inc
+++ b/Makefile.inc
@@ -209,7 +209,9 @@ endef
 # arg2: binary file name
 cbfs-files-processor-nvramtool= \
 	$(eval $(2): $(1) $(src)/mainboard/$(MAINBOARDDIR)/cmos.layout | $(objutil)/nvramtool/nvramtool ; \
-		printf "    CREATE     $(2) (from $(1))\n"; $(objutil)/nvramtool/nvramtool -y $(src)/mainboard/$(MAINBOARDDIR)/cmos.layout -D $(2).tmp -p $(1) && mv $(2).tmp $(2))
+		printf "    CREATE     $(2) (from $(1))\n"; \
+		$(objutil)/nvramtool/nvramtool -y $(src)/mainboard/$(MAINBOARDDIR)/cmos.layout -D $(2).tmp -p $(1) && \
+		mv $(2).tmp $(2))
 
 #######################################################################
 # Link VSA binary to ELF-ish stage
@@ -217,7 +219,9 @@ cbfs-files-processor-nvramtool= \
 # arg2: binary file name
 cbfs-files-processor-vsa= \
 	$(eval $(2): $(1) ; \
-		printf "    CREATE     $(2) (from $(1))\n";  $(OBJCOPY_ramstage) --set-start 0x20 --adjust-vma 0x60000 -I binary -O elf32-i386 -B i386 $(1) $(2).tmp && $(LD_ramstage) -m elf_i386 -e 0x60020 --section-start .data=0x60000 $(2).tmp -o $(2))
+		printf "    CREATE     $(2) (from $(1))\n"; \
+		$(OBJCOPY_ramstage) --set-start 0x20 --adjust-vma 0x60000 -I binary -O elf32-i386 -B i386 $(1) $(2).tmp && \
+		$(LD_ramstage) -m elf_i386 -e 0x60020 --section-start .data=0x60000 $(2).tmp -o $(2))
 
 #######################################################################
 # Reduce a .config file to its minimal representation



More information about the coreboot-gerrit mailing list