[coreboot-gerrit] Patch set updated for coreboot: asrock/e350m1: Fix build due to IASL errors
Paul Menzel (paulepanter@users.sourceforge.net)
gerrit at coreboot.org
Wed Nov 25 08:00:06 CET 2015
Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/12533
-gerrit
commit f63cd74d851c04d4a438b77268a9370c3c905122
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date: Wed Nov 25 07:07:17 2015 +0100
asrock/e350m1: Fix build due to IASL errors
Currently, building the mainboard fails due to the IASL warnings below
being treated as errors. These warnings are shown by ASL+ Optimizing
Compiler version 20150930-32, but not 20150619-64.
```
[…]
IASL build/dsdt.aml
Intel ACPI Component Architecture
ASL+ Optimizing Compiler version 20150930-32
Copyright (c) 2000 - 2015 Intel Corporation
dsdt.aml 22: if(CondRefOf(\_OSI,Local1))
Warning 3144 - ^ Method Local is set but never used (Local1)
dsdt.aml 533: CreateDWordField(Arg3,4,CDW2)
Remark 2089 - Object is not referenced ^ (Name is within method [_OSC])
dsdt.aml 534: CreateDWordField(Arg3,8,CDW3)
Remark 2089 - Object is not referenced ^ (Name is within method [_OSC])
dsdt.aml 1396: Store(PWST, PWST)
Warning 3023 - ^ Duplicate value in list (Source is the same as Target)
ASL Input: dsdt.aml - 1557 lines, 30013 bytes, 764 keywords
AML Output: dsdt.aml - 9397 bytes, 373 named objects, 391 executable opcodes
Compilation complete. 0 Errors, 2 Warnings, 2 Remarks, 462 Optimizations, 1 Constants Folded
src/arch/x86/Makefile.inc:288: recipe for target 'build/dsdt.aml' failed
make: *** [build/dsdt.aml] Error 255
```
Therefore, do not select `IASL_WARNINGS_ARE_ERRORS` to not treat these as
errors.
Change-Id: Ie4a25845416ac26f114c4706b92f37efa712222a
Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
---
src/mainboard/asrock/e350m1/Kconfig | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/src/mainboard/asrock/e350m1/Kconfig b/src/mainboard/asrock/e350m1/Kconfig
index 1c53212..f0b9f36 100644
--- a/src/mainboard/asrock/e350m1/Kconfig
+++ b/src/mainboard/asrock/e350m1/Kconfig
@@ -62,4 +62,8 @@ config VGA_BIOS_ID
string
default "1002,9802"
+# TODO: Remove this when platform ASL is fixed
+config IASL_WARNINGS_ARE_ERRORS
+ def_bool n
+
endif # BOARD_ASROCK_E350M1
More information about the coreboot-gerrit
mailing list