[coreboot-gerrit] New patch to review for coreboot: hp/pavilion_m6_1035dx: Fix IASL warning - Missing _HID object
Martin Roth (martinroth@google.com)
gerrit at coreboot.org
Wed Nov 25 00:46:57 CET 2015
Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/12532
-gerrit
commit f0471494304b08a2d3fa64a9f6d1f1e0aee11f72
Author: Martin Roth <martinroth at google.com>
Date: Tue Nov 24 16:46:44 2015 -0700
hp/pavilion_m6_1035dx: Fix IASL warning - Missing _HID object
- Add System board _HID object.
- Remove Kconfig default disabling IASL warnings as errors
Fixes warning:
dsdt.aml 64: Device (MB) {
Warning 3141 - ^ Missing dependency
(Device object requires a _HID or _ADR in same scope)
Change-Id: I4fa6ab2a6744d58ded8b0feb361e002d90e11474
Signed-off-by: Martin Roth <martinroth at google.com>
---
src/mainboard/hp/pavilion_m6_1035dx/Kconfig | 4 ----
src/mainboard/hp/pavilion_m6_1035dx/acpi/mainboard.asl | 2 ++
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/src/mainboard/hp/pavilion_m6_1035dx/Kconfig b/src/mainboard/hp/pavilion_m6_1035dx/Kconfig
index 24ec632..f78cfba 100644
--- a/src/mainboard/hp/pavilion_m6_1035dx/Kconfig
+++ b/src/mainboard/hp/pavilion_m6_1035dx/Kconfig
@@ -65,8 +65,4 @@ config VGA_BIOS_ID
string
default "1002,9900"
-# TODO: Remove this when platform ASL is fixed
-config IASL_WARNINGS_ARE_ERRORS
- def_bool n
-
endif # BOARD_HP_PAVILION_M6_1035DX
diff --git a/src/mainboard/hp/pavilion_m6_1035dx/acpi/mainboard.asl b/src/mainboard/hp/pavilion_m6_1035dx/acpi/mainboard.asl
index 9ef24c7..a2a8d5e 100644
--- a/src/mainboard/hp/pavilion_m6_1035dx/acpi/mainboard.asl
+++ b/src/mainboard/hp/pavilion_m6_1035dx/acpi/mainboard.asl
@@ -101,6 +101,8 @@ Scope (\_SB) {
}
Device (MB) {
+ Name(_HID, EisaId("PNP0C01")) // System Board
+
/* Lid open */
Method (LIDO) { /* Stub */ }
/* Lid closed */
More information about the coreboot-gerrit
mailing list