[coreboot-gerrit] Patch merged into coreboot/master: google/rambi: Fix IASL warnings _CRS must return a value

gerrit at coreboot.org gerrit at coreboot.org
Tue Nov 24 22:42:02 CET 2015


the following patch was just integrated into master:
commit c5fb1a2ea8925cad750183c16a03214e43961607
Author: Martin Roth <martinroth at google.com>
Date:   Mon Nov 23 14:03:13 2015 -0700

    google/rambi: Fix IASL warnings _CRS must return a value
    
    The Touchpad and Touchscreen _CRS methods do not return an interrupt
    value if the I2c busses that the devices are on are not in PCI mode.
    
    Previously they didn't return any value if they weren't in PCI mode.
    This patch has them return an empty resource template.
    
    Fixes these warnings:
    dsdt.aml 2813: Method (_CRS)
    Warning  3115 -          ^ Not all control paths return a value (_CRS)
    dsdt.aml 2813: Method (_CRS)
    Warning  3107 -          ^ Reserved method must return a value
    (Buffer required for _CRS)
    
    dsdt.aml 2832: Method (_CRS)
    Warning  3115 -          ^ Not all control paths return a value (_CRS)
    dsdt.aml 2832: Method (_CRS)
    Warning  3107 -          ^ Reserved method must return a value
    (Buffer required for _CRS)
    
    Change-Id: I02a29e56a513ec34a98534fb4a8d51df3b70a522
    Signed-off-by: Martin Roth <martinroth at google.com>
    Reviewed-on: https://review.coreboot.org/12519
    Tested-by: build bot (Jenkins)
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>


See https://review.coreboot.org/12519 for details.

-gerrit



More information about the coreboot-gerrit mailing list