[coreboot-gerrit] Patch merged into coreboot/master: superio/smsc/mec1308: Fix IASL warnings

gerrit at coreboot.org gerrit at coreboot.org
Tue Nov 24 22:30:21 CET 2015


the following patch was just integrated into master:
commit 56033a9f2d6ceed6ad27450d866be46eb49abf8b
Author: Martin Roth <martinroth at google.com>
Date:   Mon Nov 23 14:34:51 2015 -0700

    superio/smsc/mec1308: Fix IASL warnings
    
    The SIO device needs to provide an _ADR object with the IO
    address as well as the address in the OperationRegion.
    
    ACPI provides two different Resource Descriptor Macros to describe the
    I/O areas required for a device.  The FixedIO macro is only valid for
    10-bit IO addresses.  Use the IO macro instead.
    
    Thank you to recent IASL that allows for addition in the ASL file.  :)
    
    Fixes these warnings:
    dsdt.aml   2276: Device (SIO) {
    Warning  3141 -           ^ Missing dependency
    (Device object requires a _HID or _ADR in same scope)
    dsdt.aml   2390:    FixedIO (0xa00, 0x34)
    Warning  3060 -                 ^ Maximum 10-bit ISA address (0x3FF)
    dsdt.aml   2394:    FixedIO (0xa00, 0x34)
    Warning  3060 -                 ^ Maximum 10-bit ISA address (0x3FF)
    
    Lumpy now compiles its ASL tables with no warnings.  Re-enable
    Warnings as errors.
    
    Change-Id: Id26e234eadaa3b966e8f769cb9f9fb7ea64fc9e3
    Signed-off-by: Martin Roth <martinroth at google.com>
    Reviewed-on: https://review.coreboot.org/12520
    Tested-by: build bot (Jenkins)
    Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>


See https://review.coreboot.org/12520 for details.

-gerrit



More information about the coreboot-gerrit mailing list