[coreboot-gerrit] Patch merged into coreboot/master: FSP 1.0: Fix CAR issues - broken timestamps and console
gerrit at coreboot.org
gerrit at coreboot.org
Tue Nov 24 21:21:45 CET 2015
the following patch was just integrated into master:
commit e597e63e49da740516732a2c8453bafdb7ac4fcd
Author: Ben Gardner <gardner.ben at gmail.com>
Date: Mon Nov 23 20:47:59 2015 -0600
FSP 1.0: Fix CAR issues - broken timestamps and console
FSP 1.0 has a fixed-size temporary cache size and address and the entire
cache is migrated in the FSP FspInitEntry() function.
Previous code expected the symbol _car_data_start to be the same as
CONFIG_DCACHE_RAM_BASE and _car_data_end to be the same as
_preram_cbmem_console.
FSP 1.0 is the only one that migrates _preram_cbmem_console.
Others leave that where it is and extract the early console data in
cbmemc_reinit(). Special handling is needed to handle that.
Commit dd6fa93d broke both assumptions and so broke the timestamp table
and console.
The fix is to use CONFIG_DCACHE_RAM_BASE when calculating the offset and
to use _preram_cbmem_console instead of _car_data_end for the console
check.
Change-Id: I6db109269b3537f7cb1300357c483ff2a745ffa7
Signed-off-by: Ben Gardner <gardner.ben at gmail.com>
Reviewed-on: http://review.coreboot.org/12511
Tested-by: build bot (Jenkins)
Reviewed-by: Aaron Durbin <adurbin at chromium.org>
Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>
Reviewed-by: Martin Roth <martinroth at google.com>
See http://review.coreboot.org/12511 for details.
-gerrit
More information about the coreboot-gerrit
mailing list