[coreboot-gerrit] New patch to review for coreboot: baytrail: fix missing braces around ir_base to fix IRQ routing

Alexander Couzens (lynxis@fe80.eu) gerrit at coreboot.org
Tue Nov 24 09:48:40 CET 2015


Alexander Couzens (lynxis at fe80.eu) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12525

-gerrit

commit afd2f5d5d5ae5167758511c04eff0ed68c0fe7d5
Author: Alexander Couzens <lynxis at fe80.eu>
Date:   Tue Nov 24 09:46:18 2015 +0100

    baytrail: fix missing braces around ir_base to fix IRQ routing
    
    Because of the missing braces /baytrail overwritten other registers
    including the IO APIC enable bit (AEN in OIC).
    
    Change-Id: I1d5aa2af6d74405a1a125af6221ac0e635a6b693
    Signed-off-by: Alexander Couzens <lynxis at fe80.eu>
---
 src/soc/intel/baytrail/southcluster.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/soc/intel/baytrail/southcluster.c b/src/soc/intel/baytrail/southcluster.c
index 49c4545..090b988 100644
--- a/src/soc/intel/baytrail/southcluster.c
+++ b/src/soc/intel/baytrail/southcluster.c
@@ -184,7 +184,7 @@ static void sc_init(device_t dev)
 {
 	int i;
 	u8 *pr_base = (u8 *)(ILB_BASE_ADDRESS + 0x08);
-	u16 *ir_base = (u16 *)ILB_BASE_ADDRESS + 0x20;
+	u16 *ir_base = (u16 *)(ILB_BASE_ADDRESS + 0x20);
 	u32 *gen_pmcon1 = (u32 *)(PMC_BASE_ADDRESS + GEN_PMCON1);
 	u32 *actl = (u32 *)(ILB_BASE_ADDRESS + ACTL);
 	const struct baytrail_irq_route *ir = &global_baytrail_irq_route;



More information about the coreboot-gerrit mailing list