[coreboot-gerrit] New patch to review for coreboot: superio/smsc/mec1308: Fix IASL warnings

[Martin Roth (martinroth@google.com)]

Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12520

-gerrit

commit 19c5cb7b21812241efa5f800f2ce7b3ff7c4b4e5
Author: Martin Roth <martinroth at google.com>
Date:   Mon Nov 23 14:34:51 2015 -0700

    superio/smsc/mec1308: Fix IASL warnings
    
    The SIO device needs to provide an _ADR object with the IO
    address as well as the address in the OperationRegion.
    
    ACPI provides two different Resource Descriptor Macros to describe the
    I/O areas required for a device.  The FixedIO macro is only valid for
    10-bit IO addresses.  Changed to use the IO macro instead.
    
    Thank you to recent IASL that allows for addition in the ASL file.  :)
    
    Fixes these warnings:
    dsdt.aml   2276: Device (SIO) {
    Warning  3141 -           ^ Missing dependency
    (Device object requires a _HID or _ADR in same scope)
    dsdt.aml   2390:    FixedIO (0xa00, 0x34)
    Warning  3060 -                 ^ Maximum 10-bit ISA address (0x3FF)
    dsdt.aml   2394:    FixedIO (0xa00, 0x34)
    Warning  3060 -                 ^ Maximum 10-bit ISA address (0x3FF)
    
    Lumpy now compiles its ASL tables with no warnings.  Re-Enable
    Warnings as errors.
    
    Change-Id: Id26e234eadaa3b966e8f769cb9f9fb7ea64fc9e3
    Signed-off-by: Martin Roth <martinroth at google.com>
---
 src/mainboard/samsung/lumpy/Kconfig       | 4 ----
 src/superio/smsc/mec1308/acpi/superio.asl | 5 +++--
 2 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/src/mainboard/samsung/lumpy/Kconfig b/src/mainboard/samsung/lumpy/Kconfig
index 1660c27..ac19be5 100644
--- a/src/mainboard/samsung/lumpy/Kconfig
+++ b/src/mainboard/samsung/lumpy/Kconfig
@@ -64,8 +64,4 @@ config EARLY_PCI_MMIO_BASE
 
 endif
 
-# TODO: Remove this when platform ASL is fixed
-config IASL_WARNINGS_ARE_ERRORS
-	def_bool n
-
 endif # BOARD_SAMSUNG_LUMPY
diff --git a/src/superio/smsc/mec1308/acpi/superio.asl b/src/superio/smsc/mec1308/acpi/superio.asl
index 7251259..6794448 100644
--- a/src/superio/smsc/mec1308/acpi/superio.asl
+++ b/src/superio/smsc/mec1308/acpi/superio.asl
@@ -16,6 +16,7 @@
 // Scope is \_SB.PCI0.LPCB
 
 Device (SIO) {
+	Name (_ADR, 0x2E)
 	OperationRegion (SIOA, SystemIO, 0x2E, 0x02)
 	Field (SIOA, ByteAcc, NoLock, Preserve)
 	{
@@ -245,12 +246,12 @@ Device (SIO) {
 
 		Name (_CRS, ResourceTemplate()
 		{
-			FixedIO (SIO_SMBX_IO0, 0x34)
+			IO (Decode16, SIO_SMBX_IO0, SIO_SMBX_IO0 + 0x34, 0x01, 0x34)
 		})
 
 		Name (_PRS, ResourceTemplate()
 		{
-			FixedIO (SIO_SMBX_IO0, 0x34)
+			IO (Decode16, SIO_SMBX_IO0, SIO_SMBX_IO0 + 0x34, 0x01, 0x34)
 		})
 	}
 #endif