[coreboot-gerrit] Patch set updated for coreboot: northbridge/amd/amdfam10: Rename mislabeled iommu nvram option to gart

Timothy Pearson (tpearson@raptorengineeringinc.com) gerrit at coreboot.org
Mon Nov 23 19:53:11 CET 2015


Timothy Pearson (tpearson at raptorengineeringinc.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12046

-gerrit

commit 07050f67a514f37707829621b048d45f835da47c
Author: Timothy Pearson <tpearson at raptorengineeringinc.com>
Date:   Tue Aug 11 17:52:03 2015 -0500

    northbridge/amd/amdfam10: Rename mislabeled iommu nvram option to gart
    
    Change-Id: Ia24102e164eb5753ade3f9b5ab21eba2fa60836b
    Signed-off-by: Timothy Pearson <tpearson at raptorengineeringinc.com>
---
 src/mainboard/advansus/a785e-i/cmos.layout            |  2 +-
 src/mainboard/amd/bimini_fam10/cmos.layout            |  2 +-
 src/mainboard/amd/mahogany_fam10/cmos.layout          |  2 +-
 src/mainboard/amd/serengeti_cheetah_fam10/cmos.layout |  2 +-
 src/mainboard/amd/tilapia_fam10/cmos.layout           |  2 +-
 src/mainboard/asus/kfsn4-dre/cmos.layout              |  2 +-
 src/mainboard/asus/kgpe-d16/cmos.layout               |  2 +-
 src/mainboard/asus/m4a78-em/cmos.layout               |  2 +-
 src/mainboard/asus/m4a785-m/cmos.layout               |  2 +-
 src/mainboard/asus/m4a785t-m/cmos.layout              |  2 +-
 src/mainboard/asus/m5a88-v/cmos.layout                |  2 +-
 src/mainboard/avalue/eax-785e/cmos.layout             |  2 +-
 src/mainboard/gigabyte/ma785gm/cmos.layout            |  2 +-
 src/mainboard/gigabyte/ma785gmt/cmos.layout           |  2 +-
 src/mainboard/gigabyte/ma78gm/cmos.layout             |  2 +-
 src/mainboard/hp/dl165_g6_fam10/cmos.layout           |  2 +-
 src/mainboard/iei/kino-780am2-fam10/cmos.layout       |  2 +-
 src/mainboard/jetway/pa78vm5/cmos.layout              |  2 +-
 src/mainboard/msi/ms9652_fam10/cmos.layout            |  2 +-
 src/mainboard/supermicro/h8dmr_fam10/cmos.layout      |  2 +-
 src/mainboard/supermicro/h8qme_fam10/cmos.layout      |  2 +-
 src/mainboard/supermicro/h8scm_fam10/cmos.layout      |  2 +-
 src/mainboard/tyan/s2912_fam10/cmos.layout            |  2 +-
 src/northbridge/amd/amdfam10/misc_control.c           | 12 ++++++------
 24 files changed, 29 insertions(+), 29 deletions(-)

diff --git a/src/mainboard/advansus/a785e-i/cmos.layout b/src/mainboard/advansus/a785e-i/cmos.layout
index 0ad18a2..bf58aac 100644
--- a/src/mainboard/advansus/a785e-i/cmos.layout
+++ b/src/mainboard/advansus/a785e-i/cmos.layout
@@ -12,7 +12,7 @@ entries
 412          4       e       6        debug_level
 440          4       e       9        slow_cpu
 444          1       e       1        nmi
-445          1       e       1        iommu
+445          1       e       1        gart
 456          1       e       1        ECC_memory
 728        256       h       0        user_data
 984         16       h       0        check_sum
diff --git a/src/mainboard/amd/bimini_fam10/cmos.layout b/src/mainboard/amd/bimini_fam10/cmos.layout
index 0ad18a2..bf58aac 100644
--- a/src/mainboard/amd/bimini_fam10/cmos.layout
+++ b/src/mainboard/amd/bimini_fam10/cmos.layout
@@ -12,7 +12,7 @@ entries
 412          4       e       6        debug_level
 440          4       e       9        slow_cpu
 444          1       e       1        nmi
-445          1       e       1        iommu
+445          1       e       1        gart
 456          1       e       1        ECC_memory
 728        256       h       0        user_data
 984         16       h       0        check_sum
diff --git a/src/mainboard/amd/mahogany_fam10/cmos.layout b/src/mainboard/amd/mahogany_fam10/cmos.layout
index 0ad18a2..bf58aac 100644
--- a/src/mainboard/amd/mahogany_fam10/cmos.layout
+++ b/src/mainboard/amd/mahogany_fam10/cmos.layout
@@ -12,7 +12,7 @@ entries
 412          4       e       6        debug_level
 440          4       e       9        slow_cpu
 444          1       e       1        nmi
-445          1       e       1        iommu
+445          1       e       1        gart
 456          1       e       1        ECC_memory
 728        256       h       0        user_data
 984         16       h       0        check_sum
diff --git a/src/mainboard/amd/serengeti_cheetah_fam10/cmos.layout b/src/mainboard/amd/serengeti_cheetah_fam10/cmos.layout
index 14e45ef..3c0a4ed 100644
--- a/src/mainboard/amd/serengeti_cheetah_fam10/cmos.layout
+++ b/src/mainboard/amd/serengeti_cheetah_fam10/cmos.layout
@@ -31,7 +31,7 @@ entries
 412          4       e       6        debug_level
 440          4       e       9        slow_cpu
 444          1       e       1        nmi
-445          1       e       1        iommu
+445          1       e       1        gart
 446          1       e       1        power_on_after_fail
 456          1       e       1        ECC_memory
 457          1       e       1        ECC_redirection
diff --git a/src/mainboard/amd/tilapia_fam10/cmos.layout b/src/mainboard/amd/tilapia_fam10/cmos.layout
index 0ad18a2..bf58aac 100644
--- a/src/mainboard/amd/tilapia_fam10/cmos.layout
+++ b/src/mainboard/amd/tilapia_fam10/cmos.layout
@@ -12,7 +12,7 @@ entries
 412          4       e       6        debug_level
 440          4       e       9        slow_cpu
 444          1       e       1        nmi
-445          1       e       1        iommu
+445          1       e       1        gart
 456          1       e       1        ECC_memory
 728        256       h       0        user_data
 984         16       h       0        check_sum
diff --git a/src/mainboard/asus/kfsn4-dre/cmos.layout b/src/mainboard/asus/kfsn4-dre/cmos.layout
index 66bc3a0..bd5fdbe 100644
--- a/src/mainboard/asus/kfsn4-dre/cmos.layout
+++ b/src/mainboard/asus/kfsn4-dre/cmos.layout
@@ -31,7 +31,7 @@ entries
 412          4       e       6        debug_level
 440          4       e       9        slow_cpu
 444          1       e       1        nmi
-445          1       e       1        iommu
+445          1       e       1        gart
 446          1       e       1        power_on_after_fail
 456          1       e       1        ECC_memory
 457          1       e       1        ECC_redirection
diff --git a/src/mainboard/asus/kgpe-d16/cmos.layout b/src/mainboard/asus/kgpe-d16/cmos.layout
index 648091a..a34547a 100644
--- a/src/mainboard/asus/kgpe-d16/cmos.layout
+++ b/src/mainboard/asus/kgpe-d16/cmos.layout
@@ -31,7 +31,7 @@ entries
 412          4       e       6        debug_level
 440          4       e       9        slow_cpu
 444          1       e       1        nmi
-445          1       e       1        iommu
+445          1       e       1        gart
 446          2       e       3        power_on_after_fail
 456          1       e       1        ECC_memory
 457          1       e       1        ECC_redirection
diff --git a/src/mainboard/asus/m4a78-em/cmos.layout b/src/mainboard/asus/m4a78-em/cmos.layout
index 0ad18a2..bf58aac 100644
--- a/src/mainboard/asus/m4a78-em/cmos.layout
+++ b/src/mainboard/asus/m4a78-em/cmos.layout
@@ -12,7 +12,7 @@ entries
 412          4       e       6        debug_level
 440          4       e       9        slow_cpu
 444          1       e       1        nmi
-445          1       e       1        iommu
+445          1       e       1        gart
 456          1       e       1        ECC_memory
 728        256       h       0        user_data
 984         16       h       0        check_sum
diff --git a/src/mainboard/asus/m4a785-m/cmos.layout b/src/mainboard/asus/m4a785-m/cmos.layout
index 0ad18a2..bf58aac 100644
--- a/src/mainboard/asus/m4a785-m/cmos.layout
+++ b/src/mainboard/asus/m4a785-m/cmos.layout
@@ -12,7 +12,7 @@ entries
 412          4       e       6        debug_level
 440          4       e       9        slow_cpu
 444          1       e       1        nmi
-445          1       e       1        iommu
+445          1       e       1        gart
 456          1       e       1        ECC_memory
 728        256       h       0        user_data
 984         16       h       0        check_sum
diff --git a/src/mainboard/asus/m4a785t-m/cmos.layout b/src/mainboard/asus/m4a785t-m/cmos.layout
index 0ad18a2..bf58aac 100644
--- a/src/mainboard/asus/m4a785t-m/cmos.layout
+++ b/src/mainboard/asus/m4a785t-m/cmos.layout
@@ -12,7 +12,7 @@ entries
 412          4       e       6        debug_level
 440          4       e       9        slow_cpu
 444          1       e       1        nmi
-445          1       e       1        iommu
+445          1       e       1        gart
 456          1       e       1        ECC_memory
 728        256       h       0        user_data
 984         16       h       0        check_sum
diff --git a/src/mainboard/asus/m5a88-v/cmos.layout b/src/mainboard/asus/m5a88-v/cmos.layout
index 0ad18a2..bf58aac 100644
--- a/src/mainboard/asus/m5a88-v/cmos.layout
+++ b/src/mainboard/asus/m5a88-v/cmos.layout
@@ -12,7 +12,7 @@ entries
 412          4       e       6        debug_level
 440          4       e       9        slow_cpu
 444          1       e       1        nmi
-445          1       e       1        iommu
+445          1       e       1        gart
 456          1       e       1        ECC_memory
 728        256       h       0        user_data
 984         16       h       0        check_sum
diff --git a/src/mainboard/avalue/eax-785e/cmos.layout b/src/mainboard/avalue/eax-785e/cmos.layout
index 0ad18a2..bf58aac 100644
--- a/src/mainboard/avalue/eax-785e/cmos.layout
+++ b/src/mainboard/avalue/eax-785e/cmos.layout
@@ -12,7 +12,7 @@ entries
 412          4       e       6        debug_level
 440          4       e       9        slow_cpu
 444          1       e       1        nmi
-445          1       e       1        iommu
+445          1       e       1        gart
 456          1       e       1        ECC_memory
 728        256       h       0        user_data
 984         16       h       0        check_sum
diff --git a/src/mainboard/gigabyte/ma785gm/cmos.layout b/src/mainboard/gigabyte/ma785gm/cmos.layout
index 0ad18a2..bf58aac 100644
--- a/src/mainboard/gigabyte/ma785gm/cmos.layout
+++ b/src/mainboard/gigabyte/ma785gm/cmos.layout
@@ -12,7 +12,7 @@ entries
 412          4       e       6        debug_level
 440          4       e       9        slow_cpu
 444          1       e       1        nmi
-445          1       e       1        iommu
+445          1       e       1        gart
 456          1       e       1        ECC_memory
 728        256       h       0        user_data
 984         16       h       0        check_sum
diff --git a/src/mainboard/gigabyte/ma785gmt/cmos.layout b/src/mainboard/gigabyte/ma785gmt/cmos.layout
index 0ad18a2..bf58aac 100644
--- a/src/mainboard/gigabyte/ma785gmt/cmos.layout
+++ b/src/mainboard/gigabyte/ma785gmt/cmos.layout
@@ -12,7 +12,7 @@ entries
 412          4       e       6        debug_level
 440          4       e       9        slow_cpu
 444          1       e       1        nmi
-445          1       e       1        iommu
+445          1       e       1        gart
 456          1       e       1        ECC_memory
 728        256       h       0        user_data
 984         16       h       0        check_sum
diff --git a/src/mainboard/gigabyte/ma78gm/cmos.layout b/src/mainboard/gigabyte/ma78gm/cmos.layout
index 0ad18a2..bf58aac 100644
--- a/src/mainboard/gigabyte/ma78gm/cmos.layout
+++ b/src/mainboard/gigabyte/ma78gm/cmos.layout
@@ -12,7 +12,7 @@ entries
 412          4       e       6        debug_level
 440          4       e       9        slow_cpu
 444          1       e       1        nmi
-445          1       e       1        iommu
+445          1       e       1        gart
 456          1       e       1        ECC_memory
 728        256       h       0        user_data
 984         16       h       0        check_sum
diff --git a/src/mainboard/hp/dl165_g6_fam10/cmos.layout b/src/mainboard/hp/dl165_g6_fam10/cmos.layout
index 73d53af..5602c70 100644
--- a/src/mainboard/hp/dl165_g6_fam10/cmos.layout
+++ b/src/mainboard/hp/dl165_g6_fam10/cmos.layout
@@ -31,7 +31,7 @@ entries
 412          4       e       6        debug_level
 440          4       e       9        slow_cpu
 444          1       e       1        nmi
-445          1       e       1        iommu
+445          1       e       1        gart
 456          1       e       1        ECC_memory
 457          1       e       1        ECC_redirection
 728        256       h       0        user_data
diff --git a/src/mainboard/iei/kino-780am2-fam10/cmos.layout b/src/mainboard/iei/kino-780am2-fam10/cmos.layout
index 0ad18a2..bf58aac 100644
--- a/src/mainboard/iei/kino-780am2-fam10/cmos.layout
+++ b/src/mainboard/iei/kino-780am2-fam10/cmos.layout
@@ -12,7 +12,7 @@ entries
 412          4       e       6        debug_level
 440          4       e       9        slow_cpu
 444          1       e       1        nmi
-445          1       e       1        iommu
+445          1       e       1        gart
 456          1       e       1        ECC_memory
 728        256       h       0        user_data
 984         16       h       0        check_sum
diff --git a/src/mainboard/jetway/pa78vm5/cmos.layout b/src/mainboard/jetway/pa78vm5/cmos.layout
index 0ad18a2..bf58aac 100644
--- a/src/mainboard/jetway/pa78vm5/cmos.layout
+++ b/src/mainboard/jetway/pa78vm5/cmos.layout
@@ -12,7 +12,7 @@ entries
 412          4       e       6        debug_level
 440          4       e       9        slow_cpu
 444          1       e       1        nmi
-445          1       e       1        iommu
+445          1       e       1        gart
 456          1       e       1        ECC_memory
 728        256       h       0        user_data
 984         16       h       0        check_sum
diff --git a/src/mainboard/msi/ms9652_fam10/cmos.layout b/src/mainboard/msi/ms9652_fam10/cmos.layout
index 14e45ef..3c0a4ed 100644
--- a/src/mainboard/msi/ms9652_fam10/cmos.layout
+++ b/src/mainboard/msi/ms9652_fam10/cmos.layout
@@ -31,7 +31,7 @@ entries
 412          4       e       6        debug_level
 440          4       e       9        slow_cpu
 444          1       e       1        nmi
-445          1       e       1        iommu
+445          1       e       1        gart
 446          1       e       1        power_on_after_fail
 456          1       e       1        ECC_memory
 457          1       e       1        ECC_redirection
diff --git a/src/mainboard/supermicro/h8dmr_fam10/cmos.layout b/src/mainboard/supermicro/h8dmr_fam10/cmos.layout
index 14e45ef..3c0a4ed 100644
--- a/src/mainboard/supermicro/h8dmr_fam10/cmos.layout
+++ b/src/mainboard/supermicro/h8dmr_fam10/cmos.layout
@@ -31,7 +31,7 @@ entries
 412          4       e       6        debug_level
 440          4       e       9        slow_cpu
 444          1       e       1        nmi
-445          1       e       1        iommu
+445          1       e       1        gart
 446          1       e       1        power_on_after_fail
 456          1       e       1        ECC_memory
 457          1       e       1        ECC_redirection
diff --git a/src/mainboard/supermicro/h8qme_fam10/cmos.layout b/src/mainboard/supermicro/h8qme_fam10/cmos.layout
index 14e45ef..3c0a4ed 100644
--- a/src/mainboard/supermicro/h8qme_fam10/cmos.layout
+++ b/src/mainboard/supermicro/h8qme_fam10/cmos.layout
@@ -31,7 +31,7 @@ entries
 412          4       e       6        debug_level
 440          4       e       9        slow_cpu
 444          1       e       1        nmi
-445          1       e       1        iommu
+445          1       e       1        gart
 446          1       e       1        power_on_after_fail
 456          1       e       1        ECC_memory
 457          1       e       1        ECC_redirection
diff --git a/src/mainboard/supermicro/h8scm_fam10/cmos.layout b/src/mainboard/supermicro/h8scm_fam10/cmos.layout
index 0ad18a2..bf58aac 100644
--- a/src/mainboard/supermicro/h8scm_fam10/cmos.layout
+++ b/src/mainboard/supermicro/h8scm_fam10/cmos.layout
@@ -12,7 +12,7 @@ entries
 412          4       e       6        debug_level
 440          4       e       9        slow_cpu
 444          1       e       1        nmi
-445          1       e       1        iommu
+445          1       e       1        gart
 456          1       e       1        ECC_memory
 728        256       h       0        user_data
 984         16       h       0        check_sum
diff --git a/src/mainboard/tyan/s2912_fam10/cmos.layout b/src/mainboard/tyan/s2912_fam10/cmos.layout
index 14e45ef..3c0a4ed 100644
--- a/src/mainboard/tyan/s2912_fam10/cmos.layout
+++ b/src/mainboard/tyan/s2912_fam10/cmos.layout
@@ -31,7 +31,7 @@ entries
 412          4       e       6        debug_level
 440          4       e       9        slow_cpu
 444          1       e       1        nmi
-445          1       e       1        iommu
+445          1       e       1        gart
 446          1       e       1        power_on_after_fail
 456          1       e       1        ECC_memory
 457          1       e       1        ECC_redirection
diff --git a/src/northbridge/amd/amdfam10/misc_control.c b/src/northbridge/amd/amdfam10/misc_control.c
index 847b599..ed932a9 100644
--- a/src/northbridge/amd/amdfam10/misc_control.c
+++ b/src/northbridge/amd/amdfam10/misc_control.c
@@ -38,7 +38,7 @@
  *
  * @param dev
  *
- * There is only one AGP aperture resource needed. The resoruce is added to
+ * There is only one AGP aperture resource needed. The resource is added to
  * the northbridge of BSP.
  *
  * The same trick can be used to augment legacy VGA resources which can
@@ -50,7 +50,7 @@
 static void mcf3_read_resources(device_t dev)
 {
 	struct resource *resource;
-	unsigned char iommu;
+	unsigned char gart;
 	/* Read the generic PCI resources */
 	pci_dev_read_resources(dev);
 
@@ -59,13 +59,13 @@ static void mcf3_read_resources(device_t dev)
 		return;
 	}
 
-	iommu = 1;
-	get_option(&iommu, "iommu");
+	gart = 1;
+	get_option(&gart, "gart");
 
-	if (iommu) {
+	if (gart) {
 		/* Add a Gart apeture resource */
 		resource = new_resource(dev, 0x94);
-		resource->size = iommu?CONFIG_AGP_APERTURE_SIZE:1;
+		resource->size = gart?CONFIG_AGP_APERTURE_SIZE:1;
 		resource->align = log2(resource->size);
 		resource->gran  = log2(resource->size);
 		resource->limit = 0xffffffff; /* 4G */



More information about the coreboot-gerrit mailing list