[coreboot-gerrit] Patch merged into coreboot/master: coreinfo: Rewrite bootlog_module
gerrit at coreboot.org
gerrit at coreboot.org
Sat Nov 21 18:03:47 CET 2015
the following patch was just integrated into master:
commit 37f4565b8b9da60c817572b0e9dd161b5815deee
Author: Yasha Cherikovsky <yasha.che3 at gmail.com>
Date: Sat Nov 14 19:21:14 2015 +0200
coreinfo: Rewrite bootlog_module
The old bootlog_module implementation was completely broken:
- It assumed that the console buffer is located at address 0x90000,
and of size 64K. It is not correct nowadays.
- It displayed the buffer in a very hacky way, the code was riddled with
TODOs and FIXMEs. Scrolling had sometimes unexpected behavior.
The new implementation:
- Uses the cbmem console as the source of data.
It takes the console information from lib_sysinfo of libpayload, which is
constructed from the coreboot tables (no more hardcoded adressess).
- Properly sanitizes the console buffer for display, which makes
scolling and display much easier to implement.
Change-Id: I3f87ec920631da2acfd3f52273228703f22f469f
Signed-off-by: Yasha Cherikovsky <yasha.che3 at gmail.com>
Reviewed-on: http://review.coreboot.org/12440
Tested-by: build bot (Jenkins)
Reviewed-by: Martin Roth <martinroth at google.com>
See http://review.coreboot.org/12440 for details.
-gerrit
More information about the coreboot-gerrit
mailing list