[coreboot-gerrit] Patch set updated for coreboot: drivers/intel/fsp1_1: Don't include files from blobs / fsp directory

Stefan Reinauer (stefan.reinauer@coreboot.org) gerrit at coreboot.org
Sat Nov 21 02:10:15 CET 2015


Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12464

-gerrit

commit c183b1a0c10c8522c2998763233670e65408d55b
Author: Stefan Reinauer <stefan.reinauer at coreboot.org>
Date:   Wed Nov 18 15:26:07 2015 -0800

    drivers/intel/fsp1_1: Don't include files from blobs / fsp directory
    
    coreboot's binary policy forbids to store include files required to build
    the host binaries in the blobs directory. Hence remove the infrastructure
    to do so.
    
    Change-Id: I66d57f84cbc392bbfc1f951d13424742d2cff978
    Signed-off-by: Stefan Reinauer <stefan.reinauer at coreboot.org>
---
 src/drivers/intel/fsp1_1/Kconfig                   | 5 -----
 src/drivers/intel/fsp1_1/Makefile.inc              | 2 --
 src/drivers/intel/fsp1_1/include/fsp/soc_binding.h | 2 +-
 3 files changed, 1 insertion(+), 8 deletions(-)

diff --git a/src/drivers/intel/fsp1_1/Kconfig b/src/drivers/intel/fsp1_1/Kconfig
index 4ae3727..51fa314 100644
--- a/src/drivers/intel/fsp1_1/Kconfig
+++ b/src/drivers/intel/fsp1_1/Kconfig
@@ -66,11 +66,6 @@ config FSP_IMAGE_ID_STRING
 	  8 ASCII character byte signature string that will help match the FSP
 	  binary to a supported hardware configuration.
 
-config FSP_INCLUDE_PATH
-	string "Path for FSP specific include files"
-	help
-	  The path and filename of the Intel FSP binary for this platform.
-
 config FSP_LOC
 	hex "Intel FSP Binary location in CBFS"
 	help
diff --git a/src/drivers/intel/fsp1_1/Makefile.inc b/src/drivers/intel/fsp1_1/Makefile.inc
index a296b53..f101cc4 100644
--- a/src/drivers/intel/fsp1_1/Makefile.inc
+++ b/src/drivers/intel/fsp1_1/Makefile.inc
@@ -36,8 +36,6 @@ ramstage-y += stage_cache.c
 ramstage-$(CONFIG_GOP_SUPPORT) += vbt.c
 
 CPPFLAGS_common += -Isrc/drivers/intel/fsp1_1/include
-# Where FspUpdVpd.h can be picked up from.
-CPPFLAGS_common += -I$(CONFIG_FSP_INCLUDE_PATH)
 
 cpu_incs-$(CONFIG_USE_GENERIC_FSP_CAR_INC) += $(src)/drivers/intel/fsp1_1/cache_as_ram.inc
 
diff --git a/src/drivers/intel/fsp1_1/include/fsp/soc_binding.h b/src/drivers/intel/fsp1_1/include/fsp/soc_binding.h
index 04b01e9..affb43f 100644
--- a/src/drivers/intel/fsp1_1/include/fsp/soc_binding.h
+++ b/src/drivers/intel/fsp1_1/include/fsp/soc_binding.h
@@ -27,7 +27,7 @@
 #pragma pack(push)
 
 /*
- * This file is found by way of the Kconfig FSP_INCLUDE_PATH option. It is
+ * This file is found in the soc / chipset directory. It is
  * a per implementation specific header. i.e. different FSP implementations
  * for different chipsets.
  */



More information about the coreboot-gerrit mailing list