[coreboot-gerrit] Patch set updated for coreboot: northbridge/amd/amdfam10: Fix invalid NUMA table

Timothy Pearson (tpearson@raptorengineeringinc.com) gerrit at coreboot.org
Sat Nov 21 00:43:36 CET 2015


Timothy Pearson (tpearson at raptorengineeringinc.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12035

-gerrit

commit 3fe4cc88ece014aeca51af2be4a3ba8fac46cdac
Author: Timothy Pearson <tpearson at raptorengineeringinc.com>
Date:   Sat Aug 8 02:40:58 2015 -0500

    northbridge/amd/amdfam10: Fix invalid NUMA table
    
    The existing code generated an invalid NUMA table
    that was rejected by Linux, leading to poor resource
    allocation.  This was due to system I/O resources
    being inserted into the table when the table should
    only contain DRAM resources.
    
    Do not include system I/O resources (i.e. resources
    with an index less than 0x10) in the NUMA table.
    
    Change-Id: I99c200382b52a99687daf266a84873d9ae2df025
    Signed-off-by: Timothy Pearson <tpearson at raptorengineeringinc.com>
---
 src/northbridge/amd/amdfam10/acpi.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/northbridge/amd/amdfam10/acpi.c b/src/northbridge/amd/amdfam10/acpi.c
index ad54abd..25df6b3 100644
--- a/src/northbridge/amd/amdfam10/acpi.c
+++ b/src/northbridge/amd/amdfam10/acpi.c
@@ -102,7 +102,8 @@ static void set_srat_mem(void *gp, struct device *dev, struct resource *res)
 	}
 
 	// need to figure out NV
-	state->current += acpi_create_srat_mem((acpi_srat_mem_t *)state->current, (res->index & 0xf), basek, sizek, 1);
+	if (res->index > 0xf)
+		state->current += acpi_create_srat_mem((acpi_srat_mem_t *)state->current, (res->index & 0xf), basek, sizek, 1);
 }
 
 static unsigned long acpi_fill_srat(unsigned long current)



More information about the coreboot-gerrit mailing list