[coreboot-gerrit] Patch merged into coreboot/master: util/cbmem: Add --rawdump <cbtable ID> and extend -l output

gerrit at coreboot.org gerrit at coreboot.org
Fri Nov 20 18:21:46 CET 2015


the following patch was just integrated into master:
commit c29e57d88c6c20476354a78a940d85289ee93f36
Author: Pratik Prajapati <pratikkumar.v.prajapati at intel.com>
Date:   Thu Sep 3 12:58:44 2015 -0700

    util/cbmem: Add --rawdump <cbtable ID> and extend -l output
    
    Changed following things,
    
    (1) cbmem -l would give both ID and Name for coreboot table along with
    START and LENGTH of each entry
    
    e.g.
    localhost ~ # cbmem -l
    CBMEM table of contents:
        NAME          ID           START      LENGTH
    <.....>
     3. TIME STAMP  54494d45  77ddd000   000002e0
     4. MRC DATA    4d524344  77ddb000   00001880
     5. ROMSTG STCK 90357ac4  77dd6000   00005000
     6. VBOOT WORK  78007343  77dd2000   00004000
     7. VBOOT       780074f0  77dd1000   00000c3c
     8. RAMSTAGE    9a357a9e  77d13000   000be000
     9. REFCODE     04efc0de  77c01000   00112000
    10. ACPI GNVS   474e5653  77c00000   00001000
    11. SMM BACKUP  07e9acee  77bf0000   00010000
    <..etc..>
    
    (2) With this patch, new command line arg "rawdump" or "-r" will be
    added to cbmem
    
    user can grab the ID with "cbmem -l" and execute "cbmem -r <ID>" to get
    raw dump of cbtable for the <ID> in interest.
    
    This change is needed to get MMA results data from cbtable. Coreboot
    stores the MMA results in cbmem. Separate post processing scripts uses
    cbmem utility to get the these data.
    
    This feature in the cbmem tool can also help debugging some issues where
    some specific ID of cbtable needs examination.
    
    BRANCH=none
    BUG=chrome-os-partner:43731
    TEST=Build and Boot kunimitsu (FAB3). Cbmem -r and -l works as described.
    Not tested on Glados
    
    CQ-DEPEND=CL:299476,CL:299475,CL:299473,CL:299509,CL:299508,CL:299507,CL:*230478,CL:*230479
    
    Change-Id: I70ba148113b4e918646b99997a9074300a9c7876
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: f60c79d845d4d4afca480b6884c564a0d5e5caf8
    Original-Change-Id: I1dde50856f0aa8d4cdd3ecf013bd58d37d76eb72
    Original-Signed-off-by: Pratik Prajapati <pratikkumar.v.prajapati at intel.com>
    Original-Signed-off-by: Icarus Sparry <icarus.w.sparry at intel.com>
    Original-Reviewed-on: https://chromium-review.googlesource.com/299474
    Original-Commit-Ready: Pratikkumar V Prajapati <pratikkumar.v.prajapati at intel.com>
    Original-Tested-by: Pratikkumar V Prajapati <pratikkumar.v.prajapati at intel.com>
    Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>
    Original-Reviewed-by: Pratikkumar V Prajapati <pratikkumar.v.prajapati at intel.com>
    Reviewed-on: http://review.coreboot.org/12482
    Tested-by: build bot (Jenkins)
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>


See http://review.coreboot.org/12482 for details.

-gerrit



More information about the coreboot-gerrit mailing list