[coreboot-gerrit] New patch to review for coreboot: chromeos: Fix Kconfig TPM warnings on systems with no LPC TPM
Martin Roth (martinroth@google.com)
gerrit at coreboot.org
Fri Nov 20 02:25:02 CET 2015
Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12497
-gerrit
commit b8a7d2e055ff46920c39adef9d65476431f28b23
Author: Martin Roth <martinroth at google.com>
Date: Thu Nov 19 18:24:30 2015 -0700
chromeos: Fix Kconfig TPM warnings on systems with no LPC TPM
Put dependecies on CHROMEOS's selection of the Kconfig symbols
TPM_INIT_FAILURE_IS_FATAL and SKIP_TPM_STARTUP_ON_NORMAL_BOOT to match
the dependencies on those symbols where they are defined in
src/drivers/pc80/tpm/Kconfig
The file that uses these only gets built in if CONFIG_LPC_TPM is
selected selected.
The warnings were:
warning: (CHROMEOS) selects TPM_INIT_FAILURE_IS_FATAL which has unmet
direct dependencies (PC80_SYSTEM && LPC_TPM)
warning: (CHROMEOS) selects SKIP_TPM_STARTUP_ON_NORMAL_BOOT which has
unmet direct dependencies (PC80_SYSTEM && LPC_TPM)
Change-Id: I7af00c79050bf511758bf29e3d57f6ff34d2a296
Signed-off-by: Martin Roth <martinroth at google.com>
---
src/vendorcode/google/chromeos/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/vendorcode/google/chromeos/Kconfig b/src/vendorcode/google/chromeos/Kconfig
index 02bb227..4d05b3e 100644
--- a/src/vendorcode/google/chromeos/Kconfig
+++ b/src/vendorcode/google/chromeos/Kconfig
@@ -22,8 +22,8 @@ config CHROMEOS
bool "Build for ChromeOS"
default n
select TPM
- select TPM_INIT_FAILURE_IS_FATAL
- select SKIP_TPM_STARTUP_ON_NORMAL_BOOT
+ select TPM_INIT_FAILURE_IS_FATAL if PC80_SYSTEM && LPC_TPM
+ select SKIP_TPM_STARTUP_ON_NORMAL_BOOT if PC80_SYSTEM && LPC_TPM
select BOOTMODE_STRAPS
select ELOG
select COLLECT_TIMESTAMPS
More information about the coreboot-gerrit
mailing list