[coreboot-gerrit] New patch to review for coreboot: x86emu: Fix some set-but-not-used warnings.

Stefan Reinauer (stefan.reinauer@coreboot.org) gerrit at coreboot.org
Fri Nov 20 00:36:45 CET 2015


Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12492

-gerrit

commit caa0b7631231ed888bff6283501994b86ca32392
Author: Stefan Reinauer <stefan.reinauer at coreboot.org>
Date:   Thu Nov 19 14:45:39 2015 -0800

    x86emu: Fix some set-but-not-used warnings.
    
    Change-Id: Ide861733d721a21b77862076bf7ad70c7ee6a472
    Original-Reviewed-by: Adam Jackson <ajax at redhat.com>
    Original-Signed-off-by: Eric Anholt <eric at anholt.net>
    Signed-off-by: Stefan Reinauer <stefan.reinauer at coreboot.org>
---
 src/device/oprom/x86emu/debug.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/src/device/oprom/x86emu/debug.c b/src/device/oprom/x86emu/debug.c
index e7a111b..bc249a9 100644
--- a/src/device/oprom/x86emu/debug.c
+++ b/src/device/oprom/x86emu/debug.c
@@ -211,9 +211,7 @@ void X86EMU_dump_memory (u16 seg, u16 off, u32 amt)
     u32 start = off & 0xfffffff0;
     u32 end  = (off+16) & 0xfffffff0;
     u32 i;
-    u32 current;
 
-    current = start;
     while (end <= off + amt) {
         printf("%04x:%04x ", seg, start);
         for (i=start; i< off; i++)
@@ -239,8 +237,6 @@ void x86emu_single_step (void)
     static int breakpoint;
     static int noDecode = 1;
 
-    char *p;
-
         if (DEBUG_BREAK()) {
                 if (M.x86.saved_ip != breakpoint) {
                         return;
@@ -256,7 +252,7 @@ void x86emu_single_step (void)
     offset = M.x86.saved_ip;
     while (!done) {
         printf("-");
-        p = fgets(s, 1023, stdin);
+        (void)fgets(s, 1023, stdin);
         cmd = parse_line(s, ps, &ntok);
         switch(cmd) {
           case 'u':



More information about the coreboot-gerrit mailing list