[coreboot-gerrit] New patch to review for coreboot: console: Add help for serial IO port selection

Martin Roth (martinroth@google.com) gerrit at coreboot.org
Thu Nov 19 19:40:56 CET 2015


Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12487

-gerrit

commit 2fc653e16cafc0d6a68354e16b5d8c65f57eb8e1
Author: Martin Roth <martinroth at google.com>
Date:   Thu Nov 19 11:40:43 2015 -0700

    console: Add help for serial IO port selection
    
    Add help and a comment about the serial IO port selection to give the
    user better feedback when a port index is selected.
    
    Change-Id: I4c1614be51aee0286308fbc5c24554e218120bf7
    Signed-off-by: Martin Roth <martinroth at google.com>
---
 src/console/Kconfig | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/src/console/Kconfig b/src/console/Kconfig
index d815637..3130ee9 100644
--- a/src/console/Kconfig
+++ b/src/console/Kconfig
@@ -43,6 +43,9 @@ if CONSOLE_SERIAL
 config UART_FOR_CONSOLE
 	int "Index for UART port to use for console"
 	default 0
+	help
+	  Select an I/O port to use for serial console:
+	    0 = 0x3f8, 1 = 0x2f8, 2 = 0x3e8, 3 = 0x2e8
 
 # FIXME: Early programming in romstage is incorrect as we should
 # program different LDN to actually change the physical port.
@@ -56,6 +59,15 @@ config TTYS0_BASE
 	help
 	  Map the COM port number to the respective I/O port.
 
+comment "Serial port base address = 0x3f8"
+depends on UART_FOR_CONSOLE = 0
+comment "Serial port base address = 0x2f8"
+depends on UART_FOR_CONSOLE = 1
+comment "Serial port base address = 0x3e8"
+depends on UART_FOR_CONSOLE = 2
+comment "Serial port base address = 0x2e8"
+depends on UART_FOR_CONSOLE = 3
+
 choice
 	prompt "Baud rate"
 	default CONSOLE_SERIAL_115200



More information about the coreboot-gerrit mailing list