[coreboot-gerrit] Patch set updated for coreboot: fsp1_0: Update Kconfig for symbols not depending on FSP binary

Martin Roth (martinroth@google.com) gerrit at coreboot.org
Thu Nov 19 16:47:30 CET 2015


Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12461

-gerrit

commit 2dadcd120cdacff92c97ffbd0bff88c8a055016d
Author: Martin Roth <martinroth at google.com>
Date:   Wed Nov 18 16:07:54 2015 -0700

    fsp1_0: Update Kconfig for symbols not depending on FSP binary
    
    There were several symbols that were inside the 'if HAVE_FSP_BIN' that
    don't really depend on having the FSP binary.  In theory, we should be
    able to build a coreboot rom and add the FSP binary later.  This doesn't
    always work in practice, but this is a step in that direction.
    
    This also fixes a Kconfig warning for Rangeley.
    
    Change-Id: I327d8fe5231d7de25f2a74b8a193deb47e4c5ee1
    Signed-off-by: Martin Roth <martinroth at google.com>
---
 src/drivers/intel/fsp1_0/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/drivers/intel/fsp1_0/Kconfig b/src/drivers/intel/fsp1_0/Kconfig
index 36bfa7c..28df90e 100644
--- a/src/drivers/intel/fsp1_0/Kconfig
+++ b/src/drivers/intel/fsp1_0/Kconfig
@@ -41,6 +41,8 @@ config FSP_FILE
 	help
 	  The path and filename of the Intel FSP binary for this platform.
 
+endif #HAVE_FSP_BIN
+
 config FSP_LOC
 	hex "Intel FSP Binary location in CBFS"
 	help
@@ -92,8 +94,6 @@ config VIRTUAL_ROM_SIZE
 	  the SPI ROMs are loaded with an 8 MB coreboot image, the virtual ROM
 	  size is 16 MB.
 
-endif #HAVE_FSP_BIN
-
 config CACHE_ROM_SIZE_OVERRIDE
 	hex "Cache ROM Size"
 	default CBFS_SIZE



More information about the coreboot-gerrit mailing list