[coreboot-gerrit] Patch set updated for coreboot: edid: Remove useless parameter from detailed_cvt_descriptor()

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Thu Nov 19 16:12:11 CET 2015


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12441

-gerrit

commit e9d975a9516add75a34aa2dff4094514149cb39e
Author: Douglas Anderson <dianders at chromium.org>
Date:   Wed Oct 28 11:19:57 2015 -0700

    edid: Remove useless parameter from detailed_cvt_descriptor()
    
    The detailed_cvt_descriptor() function takes a parameter "out" for no
    good reason.  Remove it.
    
    BRANCH=none
    BUG=chrome-os-partner:46998
    TEST=Build and boot
    
    Change-Id: I1042dba9ddf2b4b543bd07615013088be5055950
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 5c3474c9b1f9fb73f44d64d3a0592f92339da2df
    Original-Change-Id: I4d695a6dba6606d2132578ce0ab4cb612c83d0f4
    Original-Signed-off-by: Douglas Anderson <dianders at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/309598
    Original-(cherry picked from commit 39122e242e808d71a4e274e8a23e9a63f4984388)
    Original-Reviewed-on: https://chromium-review.googlesource.com/309496
    Original-Commit-Ready: David Hendricks <dhendrix at chromium.org>
    Original-Tested-by: David Hendricks <dhendrix at chromium.org>
    Original-Reviewed-by: David Hendricks <dhendrix at chromium.org>
    Original-Reviewed-by: Julius Werner <jwerner at chromium.org>
---
 src/lib/edid.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/lib/edid.c b/src/lib/edid.c
index 0f5643d..e94720e 100644
--- a/src/lib/edid.c
+++ b/src/lib/edid.c
@@ -110,7 +110,7 @@ static char *manufacturer_name(unsigned char *x)
 }
 
 static int
-detailed_cvt_descriptor(struct edid *out, unsigned char *x, int first)
+detailed_cvt_descriptor(unsigned char *x, int first)
 {
 	const unsigned char empty[3] = { 0, 0, 0 };
 	const char *names[] = { "50", "60", "75", "85" };
@@ -253,7 +253,7 @@ detailed_block(struct edid *out, unsigned char *x, int in_extension,
 				return 0;
 			}
 			for (i = 0; i < 4; i++)
-				valid_cvt &= detailed_cvt_descriptor(out, x + 6 + (i * 3), (i == 0));
+				valid_cvt &= detailed_cvt_descriptor(x + 6 + (i * 3), (i == 0));
 			c->has_valid_cvt &= valid_cvt;
 			return 1;
 		}



More information about the coreboot-gerrit mailing list