[coreboot-gerrit] New patch to review for coreboot: device/device.c: remove warning for missing apic read resources
Martin Roth (martinroth@google.com)
gerrit at coreboot.org
Thu Nov 19 04:23:44 CET 2015
Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12471
-gerrit
commit 00aaeb80dee4bbfd33840fa091915b96f3f4333a
Author: Martin Roth <martinroth at google.com>
Date: Wed Nov 18 20:23:02 2015 -0700
device/device.c: remove warning for missing apic read resources
We have had the "APIC: 00 missing read_resources" messages
for many years. It's obviously not an error, and also doesn't
cause boot failures. Therefore, remove the message.
Change-Id: I7f99c5950a3457df04e7ef6edb456b70dba9680c
Signed-off-by: Martin Roth <martinroth at google.com>
---
src/device/device.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/device/device.c b/src/device/device.c
index 55a5dfd..e23c9de 100644
--- a/src/device/device.c
+++ b/src/device/device.c
@@ -222,8 +222,9 @@ static void read_resources(struct bus *bus)
continue;
if (!curdev->ops || !curdev->ops->read_resources) {
- printk(BIOS_ERR, "%s missing read_resources\n",
- dev_path(curdev));
+ if (curdev->path.type != DEVICE_PATH_APIC)
+ printk(BIOS_ERR, "%s missing read_resources\n",
+ dev_path(curdev));
continue;
}
post_log_path(curdev);
More information about the coreboot-gerrit
mailing list