[coreboot-gerrit] New patch to review for coreboot: romcc: Allow adding non-existent paths to include path

Stefan Reinauer (stefan.reinauer@coreboot.org) gerrit at coreboot.org
Thu Nov 19 02:25:07 CET 2015


Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12469

-gerrit

commit 82bbbf3715c027b8269f1bf21b7c4990b305bfeb
Author: Stefan Reinauer <stefan.reinauer at coreboot.org>
Date:   Wed Nov 18 17:23:39 2015 -0800

    romcc: Allow adding non-existent paths to include path
    
    This models gcc's (and other compilers') behavior to not bail
    out with an error when one of the include paths does not exist.
    
    Change-Id: Ic93a55cea6b32516fd76da9b49abe7b990829889
    Signed-off-by: Stefan Reinauer <stefan.reinauer at coreboot.org>
---
 util/romcc/romcc.c | 16 +++++++++++++---
 1 file changed, 13 insertions(+), 3 deletions(-)

diff --git a/util/romcc/romcc.c b/util/romcc/romcc.c
index ad90a1e..4b43c9d 100644
--- a/util/romcc/romcc.c
+++ b/util/romcc/romcc.c
@@ -3,8 +3,8 @@
 #undef RELEASE_DATE
 #undef VERSION
 #define VERSION_MAJOR "0"
-#define VERSION_MINOR "73"
-#define RELEASE_DATE "08 May 2013"
+#define VERSION_MINOR "74"
+#define RELEASE_DATE "18 November 2015"
 #define VERSION VERSION_MAJOR "." VERSION_MINOR
 
 #include <stdarg.h>
@@ -1538,13 +1538,14 @@ static int append_string(size_t *max, const char ***vec, const char *str,
 }
 
 static void arg_error(char *fmt, ...);
+static void arg_warning(char *fmt, ...);
 static const char *identifier(const char *str, const char *end);
 
 static int append_include_path(struct compiler_state *compiler, const char *str)
 {
 	int result;
 	if (!exists(str, ".")) {
-		arg_error("Nonexistent include path: `%s'\n",
+		arg_warning("Warning: Nonexistent include path: `%s'\n",
 			str);
 	}
 	result = append_string(&compiler->include_path_count,
@@ -25083,6 +25084,15 @@ static void arg_error(char *fmt, ...)
 	exit(1);
 }
 
+static void arg_warning(char *fmt, ...)
+{
+	va_list args;
+
+	va_start(args, fmt);
+	vfprintf(stderr, fmt, args);
+	va_end(args);
+}
+
 int main(int argc, char **argv)
 {
 	const char *filename;



More information about the coreboot-gerrit mailing list