[coreboot-gerrit] New patch to review for coreboot: google/veyron_danger & veyron_emile: Fix Kconfig warnings

Martin Roth (martinroth@google.com) gerrit at coreboot.org
Thu Nov 19 00:15:21 CET 2015


Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12462

-gerrit

commit 904284825fd75ad8d9a5861c1ad5832ec99b410c
Author: Martin Roth <martinroth at google.com>
Date:   Wed Nov 18 16:13:12 2015 -0700

    google/veyron_danger & veyron_emile: Fix Kconfig warnings
    
    These platforms needed to be adjusted to fix various Kconfig warnings.
    
    Both platforms needed MAINBOARD_HAS_NATIVE_VGA_INIT because they're setting
    MAINBOARD_DO_NATIVE_VGA_INIT.
    
    veyron_emile needed a few symbols that depend on CHROMEOS to be moved
    into a new config CHROMEOS section.  This matches the other CHROMEOS
    platforms.
    
    veyron_danger needed to select MAINBOARD_HAS_CHROMEOS before the
    CHROMEOS symbol was set.
    
    Change-Id: I8c7f594ba572a02513a68095c16314006fb4e379
    Signed-off-by: Martin Roth <martinroth at google.com>
---
 src/mainboard/google/veyron_danger/Kconfig | 2 ++
 src/mainboard/google/veyron_emile/Kconfig  | 7 +++++--
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/src/mainboard/google/veyron_danger/Kconfig b/src/mainboard/google/veyron_danger/Kconfig
index 326d940..ab549f6 100644
--- a/src/mainboard/google/veyron_danger/Kconfig
+++ b/src/mainboard/google/veyron_danger/Kconfig
@@ -29,6 +29,8 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select SPI_FLASH
 	select SPI_FLASH_GIGADEVICE
 	select SPI_FLASH_WINBOND
+	select MAINBOARD_HAS_NATIVE_VGA_INIT
+	select MAINBOARD_HAS_CHROMEOS
 
 config CHROMEOS
 	select CHROMEOS_VBNV_FLASH
diff --git a/src/mainboard/google/veyron_emile/Kconfig b/src/mainboard/google/veyron_emile/Kconfig
index d6ab870..af606e0 100644
--- a/src/mainboard/google/veyron_emile/Kconfig
+++ b/src/mainboard/google/veyron_emile/Kconfig
@@ -27,14 +27,17 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select HAVE_HARD_RESET
 	select MAINBOARD_DO_NATIVE_VGA_INIT
 	select MAINBOARD_HAS_CHROMEOS
-	select PHYSICAL_REC_SWITCH
 	select RAM_CODE_SUPPORT
 	select SOC_ROCKCHIP_RK3288
 	select SPI_FLASH
 	select SPI_FLASH_GIGADEVICE
 	select SPI_FLASH_WINBOND
-	select VIRTUAL_DEV_SWITCH
+	select MAINBOARD_HAS_NATIVE_VGA_INIT
+
+config CHROMEOS
 	select CHROMEOS_VBNV_FLASH
+	select PHYSICAL_REC_SWITCH
+	select VIRTUAL_DEV_SWITCH
 
 config MAINBOARD_DIR
 	string



More information about the coreboot-gerrit mailing list