[coreboot-gerrit] Patch set updated for coreboot: google/lars & intel/kunimitsu: Fix Kconfig warnings

Martin Roth (martinroth@google.com) gerrit at coreboot.org
Thu Nov 19 00:15:19 CET 2015


Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12460

-gerrit

commit 02b58c508eb779613865ee33ff30a7e66e28d8f2
Author: Martin Roth <martinroth at google.com>
Date:   Wed Nov 18 15:19:07 2015 -0700

    google/lars & intel/kunimitsu: Fix Kconfig warnings
    
    EC_SOFTWARE_SYNC depends on CHROMEOS, so move it into the CHROMEOS section.
    This fixes the kconfig warning:
    
    warning: (CHROMEOS && BOARD_SPECIFIC_OPTIONS ...) selects
    EC_SOFTWARE_SYNC which has unmet direct dependencies
    (MAINBOARD_HAS_CHROMEOS && CHROMEOS && VBOOT_VERIFY_FIRMWARE)
    
    Change-Id: I459f48fd18c7568c4584df7d4aefa69dec3e4907
    Signed-off-by: Martin Roth <martinroth at google.com>
---
 src/mainboard/google/lars/Kconfig     | 2 +-
 src/mainboard/intel/kunimitsu/Kconfig | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/mainboard/google/lars/Kconfig b/src/mainboard/google/lars/Kconfig
index 4a1bce9..70e6726 100644
--- a/src/mainboard/google/lars/Kconfig
+++ b/src/mainboard/google/lars/Kconfig
@@ -9,7 +9,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select EC_GOOGLE_CHROMEEC_LPC
 	select EC_GOOGLE_CHROMEEC_MEC
 	select EC_GOOGLE_CHROMEEC_PD
-	select EC_SOFTWARE_SYNC
 	select HAVE_ACPI_RESUME
 	select HAVE_ACPI_TABLES
 	select HAVE_OPTION_TABLE
@@ -25,6 +24,7 @@ config CHROMEOS
 	select LID_SWITCH
 	select VBOOT_OPROM_MATTERS
 	select VIRTUAL_DEV_SWITCH
+	select EC_SOFTWARE_SYNC
 
 config IRQ_SLOT_COUNT
 	int
diff --git a/src/mainboard/intel/kunimitsu/Kconfig b/src/mainboard/intel/kunimitsu/Kconfig
index 4132e86..5a5b3cd 100644
--- a/src/mainboard/intel/kunimitsu/Kconfig
+++ b/src/mainboard/intel/kunimitsu/Kconfig
@@ -9,7 +9,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select EC_GOOGLE_CHROMEEC_LPC
 	select EC_GOOGLE_CHROMEEC_MEC
 	select EC_GOOGLE_CHROMEEC_PD
-	select EC_SOFTWARE_SYNC
 	select HAVE_ACPI_RESUME
 	select HAVE_ACPI_TABLES
 	select HAVE_OPTION_TABLE
@@ -25,6 +24,7 @@ config CHROMEOS
 	select LID_SWITCH
 	select VBOOT_OPROM_MATTERS
 	select VIRTUAL_DEV_SWITCH
+	select EC_SOFTWARE_SYNC
 
 config IRQ_SLOT_COUNT
 	int



More information about the coreboot-gerrit mailing list