[coreboot-gerrit] New patch to review for coreboot: google/chell: Turn on keyboard backlight in romstage

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Mon Nov 16 10:28:12 CET 2015


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12448

-gerrit

commit 05bb5840975ab1cf0b2693e8a4461f88b936e0c7
Author: Duncan Laurie <dlaurie at chromium.org>
Date:   Thu Nov 12 16:39:36 2015 -0800

    google/chell: Turn on keyboard backlight in romstage
    
    Use the keyboard backlight to provide indication that the system is
    booting.  This is useful for determining that a system is in S0 and
    is running BIOS code.
    
    BUG=chrome-os-partner:47435
    BRANCH=none
    TEST=boot on chell and see keyboard backlight come on early
    
    Change-Id: I43e699bcc2f34998d3d6ce33ce72c7b04b55c146
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: a3a0147b6de681365a9c995175076d5f397016fb
    Original-Change-Id: I2441c28431e71b13b70e6533e175d29ccfd8d7e9
    Original-Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/312358
    Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>
---
 src/mainboard/google/chell/romstage.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/mainboard/google/chell/romstage.c b/src/mainboard/google/chell/romstage.c
index 6aac80f..ecaae3a 100644
--- a/src/mainboard/google/chell/romstage.c
+++ b/src/mainboard/google/chell/romstage.c
@@ -39,6 +39,10 @@ void mainboard_romstage_entry(struct romstage_params *params)
 	/* Ensure the EC and PD are in the right mode for recovery */
 	google_chromeec_early_init();
 
+	/* Turn on keyboard backlight to indicate we are booting */
+	if (params->power_state->prev_sleep_state != SLEEP_STATE_S3)
+		google_chromeec_kbbacklight(100);
+
 	early_config_gpio();
 
 	/* Fill out PEI DATA */



More information about the coreboot-gerrit mailing list