[coreboot-gerrit] New patch to review for coreboot: Kconfig: Remove warning about format string

Zheng Bao (zheng.bao@amd.com) gerrit at coreboot.org
Mon Nov 9 17:27:07 CET 2015


Zheng Bao (zheng.bao at amd.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12366

-gerrit

commit 3a3bd4c1d6b05d51bfa386ecb9e1181e6a9052ad
Author: Zheng Bao <fishbaozi at gmail.com>
Date:   Tue Nov 10 00:26:00 2015 +0800

    Kconfig: Remove warning about format string
    
    Clang set -Wformat-security as default, which causes
    build waring.
    
    coreboot/util/kconfig/conf.c:79:10: warning:
     format string is not a string literal (potentially insecure)
     [-Wformat-security]
       printf(_("aborted!\n\n"));
             ^~~~~~~~~~~~~~~~~
    
    Change-Id: I10740aea21a21db7dafa3afd065a463fac4b2df9
    Signed-off-by: Zheng Bao <fishbaozi at gmail.com>
---
 util/kconfig/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/util/kconfig/Makefile b/util/kconfig/Makefile
index 243f763..e916495 100644
--- a/util/kconfig/Makefile
+++ b/util/kconfig/Makefile
@@ -375,7 +375,7 @@ $(objk)/nconf.o: $(srck)/nconf.c
 $(objk)/nconf.gui.o: $(srck)/nconf.gui.c
 	$(HOSTCC) $(HOSTCFLAGS) $(HOST_EXTRACFLAGS) -c -o $@ $<
 $(objk)/conf.o: $(srck)/conf.c
-	$(HOSTCC) $(HOSTCFLAGS) $(HOST_EXTRACFLAGS) -c -o $@ $<
+	$(HOSTCC) $(HOSTCFLAGS) $(HOST_EXTRACFLAGS) -Wno-format-security -c -o $@ $<
 $(objk)/regex.o: $(srck)/regex.c
 	$(HOSTCC) $(HOSTCFLAGS) $(HOST_EXTRACFLAGS) -DHAVE_STRING_H -c -o $@ $<
 



More information about the coreboot-gerrit mailing list