[coreboot-gerrit] Patch set updated for coreboot: Revert "AMD OemS3Save: refactor for Merlin Falcon"

[Kyösti Mälkki (kyosti.malkki@gmail.com)]

Kyösti Mälkki (kyosti.malkki at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12282

-gerrit

commit 3f7006426943ed61d4cab50f4a1e70cb871b6db7
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date:   Sat Oct 31 18:06:52 2015 +0200

    Revert "AMD OemS3Save: refactor for Merlin Falcon"
    
    This reverts commit d3deecdd9c5c0a8031f2ea9d6c90e0997f123d93.
    
    Do not mix open-source AGESA and binary PI trees. Once you have
    working S3 support for binaryPI platforms, add the adapted
    oem_s3.c file as northbridge/amd/pi/oem_s3.c instead.
    
    Change-Id: I7c981d0023a5c0225e046f9c0104acfa07436b79
    Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
---
 src/northbridge/amd/agesa/agesawrapper.h | 2 +-
 src/northbridge/amd/agesa/oem_s3.c       | 8 +-------
 2 files changed, 2 insertions(+), 8 deletions(-)

diff --git a/src/northbridge/amd/agesa/agesawrapper.h b/src/northbridge/amd/agesa/agesawrapper.h
index d9938ac..f5d52d6 100644
--- a/src/northbridge/amd/agesa/agesawrapper.h
+++ b/src/northbridge/amd/agesa/agesawrapper.h
@@ -70,6 +70,6 @@ extern const struct OEM_HOOK OemCustomize;
 /* For suspend-to-ram support. */
 AGESA_STATUS OemInitResume(AMD_RESUME_PARAMS *ResumeParams);
 AGESA_STATUS OemS3LateRestore(AMD_S3LATE_PARAMS *S3LateParams);
-AGESA_STATUS OemS3Save(void *vS3SaveParams);
+AGESA_STATUS OemS3Save(AMD_S3SAVE_PARAMS *S3SaveParams);
 
 #endif /* _AGESAWRAPPER_H_ */
diff --git a/src/northbridge/amd/agesa/oem_s3.c b/src/northbridge/amd/agesa/oem_s3.c
index b71aff5..8cce0e7 100644
--- a/src/northbridge/amd/agesa/oem_s3.c
+++ b/src/northbridge/amd/agesa/oem_s3.c
@@ -113,15 +113,9 @@ static int spi_SaveS3info(u32 pos, u32 size, u8 *buf, u32 len)
 
 static u8 MTRRStorage[S3_DATA_MTRR_SIZE];
 
-AGESA_STATUS OemS3Save(void *vS3SaveParams)
+AGESA_STATUS OemS3Save(AMD_S3SAVE_PARAMS *S3SaveParams)
 {
-#if IS_ENABLED(CONFIG_CPU_AMD_PI_00660F01)
-	AMD_RTB_PARAMS *S3SaveParams = (AMD_RTB_PARAMS *)vS3SaveParams;
-	S3_DATA_BLOCK *dataBlock = &S3SaveParams->S3DataBlock;
-#else
-	AMD_S3SAVE_PARAMS *S3SaveParams = (AMD_S3SAVE_PARAMS *)vS3SaveParams;
 	AMD_S3_PARAMS *dataBlock = &S3SaveParams->S3DataBlock;
-#endif
 	u32 MTRRStorageSize = 0;
 	uintptr_t pos, size;