[coreboot-gerrit] New patch to review for coreboot: src/console: Link die.c in bootblock without BOOTBLOCK_CONSOLE

Alexandru Gagniuc (mr.nuke.me@gmail.com) gerrit at coreboot.org
Sat Nov 7 00:54:47 CET 2015


Alexandru Gagniuc (mr.nuke.me at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12356

-gerrit

commit 359b34e286bce47abcfa30bae95b3ef849bf50a7
Author: Alexandru Gagniuc <mr.nuke.me at gmail.com>
Date:   Fri Nov 6 15:55:46 2015 -0800

    src/console: Link die.c in bootblock without BOOTBLOCK_CONSOLE
    
    Without BOOTBLOCK_CONSOLE any call to die() fails due to die() symbol
    not being defined at link time. die() is not is dependent on the
    console backend, and can function without it (the prink gets no-oped).
    
    Change-Id: I6cecafb576c3b1e901f3927c777f6282174fb259
    Signed-off-by: Alexandru Gagniuc <mr.nuke.me at gmail.com>
---
 src/console/Makefile.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/console/Makefile.inc b/src/console/Makefile.inc
index a5f4318..0c61123 100644
--- a/src/console/Makefile.inc
+++ b/src/console/Makefile.inc
@@ -20,7 +20,7 @@ romstage-y += die.c
 
 bootblock-$(CONFIG_BOOTBLOCK_CONSOLE) += vtxprintf.c printk.c
 bootblock-$(CONFIG_BOOTBLOCK_CONSOLE) += init.c console.c
-bootblock-$(CONFIG_BOOTBLOCK_CONSOLE) += die.c
+bootblock-y += die.c
 
 secmon-y += vtxprintf.c printk.c
 secmon-y += init.c console.c



More information about the coreboot-gerrit mailing list