[coreboot-gerrit] New patch to review for coreboot: commonlib: Remove unused static function.

Zheng Bao (zheng.bao@amd.com) gerrit at coreboot.org
Fri Nov 6 07:33:37 CET 2015


Zheng Bao (zheng.bao at amd.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12339

-gerrit

commit 1a9cee8b167191374258077a2af1911bd4572d44
Author: zbao <fishbaozi at gmail.com>
Date:   Fri Nov 6 14:28:56 2015 +0800

    commonlib: Remove unused static function.
    
    Building with Clang without option -Wno-unused-function causes building
    error. I don't know why GCC doesn't have that issue.
    
    ------------
    coreboot/src/commonlib/fsp1_1_relocate.c:47:23: error:
     unused function 'le8toh' [-Werror,-Wunused-function]
    static inline uint8_t le8toh(uint8_t byte)
                          ^
    1 error generated.
    ------------
    
    Change-Id: Iecd1e84e4321446412ef68d65dc918baf1ab45ce
    Signed-off-by: Zheng Bao <fishbaozi at gmail.com>
---
 src/commonlib/fsp1_1_relocate.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/src/commonlib/fsp1_1_relocate.c b/src/commonlib/fsp1_1_relocate.c
index c6143eb..7165d86 100644
--- a/src/commonlib/fsp1_1_relocate.c
+++ b/src/commonlib/fsp1_1_relocate.c
@@ -43,12 +43,6 @@ static int guid_compare(const EFI_GUID *le_guid, const EFI_GUID *native_guid)
 			ARRAY_SIZE(le_guid->Data4));
 }
 
-/* Provide this for symmetry when accessing UEFI fields. */
-static inline uint8_t le8toh(uint8_t byte)
-{
-	return byte;
-}
-
 static const EFI_GUID ffs2_guid = EFI_FIRMWARE_FILE_SYSTEM2_GUID;
 static const EFI_GUID fih_guid = FSP_INFO_HEADER_GUID;
 



More information about the coreboot-gerrit mailing list