[coreboot-gerrit] New patch to review for coreboot: soc/intel/braswell: Drop gfx_read_resources()

Nico Huber (nico.h@gmx.de) gerrit at coreboot.org
Thu Nov 5 23:41:33 CET 2015


Nico Huber (nico.h at gmx.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12338

-gerrit

commit 7518a8fdc3dc7e662e981db31f7bd2d9a603f732
Author: Nico Huber <nico.h at gmx.de>
Date:   Thu Nov 5 23:27:06 2015 +0100

    soc/intel/braswell: Drop gfx_read_resources()
    
    Drop the last remnant of vanished CONFIG_MARK_GRAPHICS_MEM_WRCOMB.
    
    Could not build test google/cyan and intel/strago due to lack of UEFI
    headers, OMG.
    
    Change-Id: I0b9eac5c040d24bab2b85e9b63042b6aaa9879d9
    Signed-off-by: Nico Huber <nico.h at gmx.de>
---
 src/soc/intel/braswell/gfx.c | 22 +---------------------
 1 file changed, 1 insertion(+), 21 deletions(-)

diff --git a/src/soc/intel/braswell/gfx.c b/src/soc/intel/braswell/gfx.c
index 3cbffc6..4328abb 100644
--- a/src/soc/intel/braswell/gfx.c
+++ b/src/soc/intel/braswell/gfx.c
@@ -75,28 +75,8 @@ static void gfx_init(device_t dev)
 	gfx_post_vbios_init(dev);
 }
 
-static void gfx_read_resources(device_t dev)
-{
-	printk(BIOS_SPEW, "%s/%s ( %s )\n",
-			__FILE__, __func__, dev_name(dev));
-
-	pci_dev_read_resources(dev);
-
-#if IS_ENABLED(CONFIG_MARK_GRAPHICS_MEM_WRCOMB)
-	struct resource *res;
-
-	/* Set the graphics memory to write combining. */
-	res = find_resource(dev, PCI_BASE_ADDRESS_2);
-	if (res == NULL) {
-		printk(BIOS_DEBUG, "GFX: memory resource not found.\n");
-		return;
-	}
-	res->flags |= IORESOURCE_WRCOMB;
-#endif
-}
-
 static struct device_operations gfx_device_ops = {
-	.read_resources		= gfx_read_resources,
+	.read_resources		= pci_dev_read_resources,
 	.set_resources		= pci_dev_set_resources,
 	.enable_resources	= pci_dev_enable_resources,
 	.init			= gfx_init,



More information about the coreboot-gerrit mailing list