[coreboot-gerrit] New patch to review for coreboot: fsp_model_406dx: use external microcode .h files for rangeley

[Martin Roth (martinroth@google.com)]

Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12335

-gerrit

commit 31fb3acca852fb82af7c861bc7aa302b57af90b3
Author: Martin Roth <martinroth at google.com>
Date:   Thu Nov 5 09:00:20 2015 -0700

    fsp_model_406dx: use external microcode .h files for rangeley
    
    The microcode for the Rangeley chip is supplied as .h files in the
    Rangeley FSP package.
    
    Change-Id: I30e7436f26a247bc9431f249becfa5fe8c581be7
    Signed-off-by: Martin Roth <martinroth at google.com>
---
 src/cpu/intel/fsp_model_406dx/Kconfig      | 8 ++++----
 src/cpu/intel/fsp_model_406dx/Makefile.inc | 3 ---
 2 files changed, 4 insertions(+), 7 deletions(-)

diff --git a/src/cpu/intel/fsp_model_406dx/Kconfig b/src/cpu/intel/fsp_model_406dx/Kconfig
index 5827c84..03f9a1f 100644
--- a/src/cpu/intel/fsp_model_406dx/Kconfig
+++ b/src/cpu/intel/fsp_model_406dx/Kconfig
@@ -32,6 +32,7 @@ config CPU_SPECIFIC_OPTIONS
 	select PARALLEL_CPU_INIT
 	select TSC_SYNC_MFENCE
 	select LAPIC_MONOTONIC_TIMER
+	select USES_MICROCODE_HEADER_FILES
 
 choice
 	prompt "Rangeley CPU Stepping"
@@ -53,9 +54,8 @@ config ENABLE_VMX
 	bool "Enable VMX for virtualization"
 	default n
 
-config CPU_MICROCODE_CBFS_LOC
-	hex
-	depends on SUPPORT_CPU_UCODE_IN_CBFS
-	default 0xfff60040
+config CPU_MICROCODE_HEADER_FILES
+	string
+	default "../intel/cpu/rangeley/microcode/microcode-m01406d000e.h ../intel/cpu/rangeley/microcode/microcode-m01406d811d.h "
 
 endif #CPU_INTEL_FSP_MODEL_406DX
diff --git a/src/cpu/intel/fsp_model_406dx/Makefile.inc b/src/cpu/intel/fsp_model_406dx/Makefile.inc
index 7e18f1b..bb534a4 100644
--- a/src/cpu/intel/fsp_model_406dx/Makefile.inc
+++ b/src/cpu/intel/fsp_model_406dx/Makefile.inc
@@ -19,6 +19,3 @@ subdirs-y += ../../x86/name
 ramstage-y += acpi.c
 
 CPPFLAGS_romstage += -I$(src)/cpu/intel/fsp_model_406dx
-# We don't have microcode for this CPU
-# Use CONFIG_CPU_MICROCODE_CBFS_EXTERNAL with a binary microcode file
-# cpu_microcode_bins += ???